Automate GitHub Release Draft

[razo7]

Similar to the rest of Medik8s operators we add an automation for the creation of Github Release upon Git tag creation.

ECOPROJECT-1128

1. Add Github Action step for building the draft.
2. Use container-build-community target for CI so quay.io/medik8s will store SNR's community version for K8s.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [razo7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[razo7]

/retest

[razo7]

/retest

[razo7]

/retest

[mshitrit]

/lgtm

[razo7]

/retest

[razo7]

/retest

[mshitrit]

/retest

[razo7]

In this PR I also wanted to update hosted runner Ubuntu image for github-actions - ubuntu-20.04 -> ubuntu-22.04, but it introduced an error running make test in dockerized go. See for example the below error from last Github CI run with ubuntu-22.04 :

/home/go/src/github.com/medik8s/self-node-remediation-operator/bin/controller-gen/v0.12.0/controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
/home/go/src/github.com/medik8s/self-node-remediation-operator/bin/controller-gen/v0.12.0/controller-gen: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.32' not found (required by /home/go/src/github.com/medik8s/self-node-remediation-operator/bin/controller-gen/v0.12.0/controller-gen) /home/go/src/github.com/medik8s/self-node-remediation-operator/bin/controller-gen/v0.12.0/controller-gen: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.34' not found (required by /home/go/src/github.com/medik8s/self-node-remediation-operator/bin/controller-gen/v0.12.0/controller-gen)
make: *** [Makefile:138: manifests] Error 1

For more context see golang/go#58550

[mshitrit]

/lgtm

[slintes]

In this PR I also wanted to update hosted runner Ubuntu image for github-actions - ubuntu-20.04 -> ubuntu-22.04, but it introduced an error running make test in dockerized go. See for example the below error from last Github CI run with ubuntu-22.04 :

/home/go/src/github.com/medik8s/self-node-remediation-operator/bin/controller-gen/v0.12.0/controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
/home/go/src/github.com/medik8s/self-node-remediation-operator/bin/controller-gen/v0.12.0/controller-gen: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.32' not found (required by /home/go/src/github.com/medik8s/self-node-remediation-operator/bin/controller-gen/v0.12.0/controller-gen) /home/go/src/github.com/medik8s/self-node-remediation-operator/bin/controller-gen/v0.12.0/controller-gen: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.34' not found (required by /home/go/src/github.com/medik8s/self-node-remediation-operator/bin/controller-gen/v0.12.0/controller-gen)
make: *** [Makefile:138: manifests] Error 1

For more context see golang/go#58550

Following the discussion you linked to, this an issue with the GCC version when using dynamically linked Go builds. We do static builds though (CGO_ENABLED=0). The missing part is: adding CGO_ENABLED=0 to the go test command as well. Maybe you want to give it a try?

[razo7]

In this PR I also wanted to update hosted runner Ubuntu image for github-actions - ubuntu-20.04 -> ubuntu-22.04, but it introduced an error running make test in dockerized go. See for example the below error from last Github CI run with ubuntu-22.04 :

/home/go/src/github.com/medik8s/self-node-remediation-operator/bin/controller-gen/v0.12.0/controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
/home/go/src/github.com/medik8s/self-node-remediation-operator/bin/controller-gen/v0.12.0/controller-gen: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.32' not found (required by /home/go/src/github.com/medik8s/self-node-remediation-operator/bin/controller-gen/v0.12.0/controller-gen) /home/go/src/github.com/medik8s/self-node-remediation-operator/bin/controller-gen/v0.12.0/controller-gen: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.34' not found (required by /home/go/src/github.com/medik8s/self-node-remediation-operator/bin/controller-gen/v0.12.0/controller-gen)
make: *** [Makefile:138: manifests] Error 1

For more context see golang/go#58550

Following the discussion you linked to, this an issue with the GCC version when using dynamically linked Go builds. We do static builds though (CGO_ENABLED=0). The missing part is: adding CGO_ENABLED=0 to the go test command as well. Maybe you want to give it a try?

Thanks for sharing Marc.
I am not sure it will resolve the problem, since the error came from running make test in dockerized go, but not from the actual running of the unit tests.
IIUC it came from running the manifests target, since the above error include the following line /home/go/src/github.com/medik8s/self-node-remediation-operator/bin/controller-gen/v0.12.0/controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases which match the call for target manifests.

I tried to add CGO_ENABLED=0 as an environment variable of the dockerized Go, but it didn't help.

[slintes]

I see. So the controller-gen binary is the problem. It's already installed (=compiled) in an earlier test step, outside of the DOCKER_GO container. Can you try adding CGO_ENABLED=0 to the go-install-tool here? 🤔
https://github.com/medik8s/self-node-remediation/blob/main/Makefile#L263

[razo7]

I see. So the controller-gen binary is the problem. It's already installed (=compiled) in an earlier test step, outside of the DOCKER_GO container. Can you try adding CGO_ENABLED=0 to the go-install-tool here? thinking https://github.com/medik8s/self-node-remediation/blob/main/Makefile#L263

Sounds like a good idea, I will open a new PR for that 👍🏻