Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show-screenpipe-shortcut #524

Merged
merged 10 commits into from
Oct 20, 2024

Conversation

EzraEllette
Copy link
Contributor

@EzraEllette EzraEllette commented Oct 17, 2024


name: add screenpipe overlay shortcut
about: submit changes to the project
title: "[pr] "
labels: ''
assignees: ''


/claim #513

description

brief description of the changes in this pr.

related issue: #

type of change

  • bug fix
  • new feature
  • breaking change
  • documentation update

how to test

checklist

  • i have read the CONTRIBUTING.md file
  • i have added the custom cursor AI prompt to my settings as mentioned in CONTRIBUTING.md and used to write this PR
  • my code follows the project's style guidelines
  • i have performed a self-review of my code
  • i have updated the documentation if necessary
  • my changes generate no new warnings
  • i have added tests that prove my fix is effective or that my feature works
  • all tests pass locally with my changes

additional notes

any other relevant information about the pr.

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
screenpipe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 6:14pm

};

let show_window_shortcut =
Shortcut::new(Some(Modifiers::META.union(Modifiers::SHIFT)), Code::KeyZ);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance to make this shortcut changeable in settings?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's difficult

Doing it now...

@EzraEllette
Copy link
Contributor Author

@louis030195 Mostly finished. need to figure out activation policy settings. Looking into issues you mentioned

@louis030195
Copy link
Collaborator

@tribhuwan-kumar curious how it behave on windows?

few (minor) weird behaviour on macos:

  • screenpipe on top of cursor (full screen cursor) when i click on minus it does not reduce (but cross does)
  • setting full screen only set 80% height somehow
  • i expected to press key and it would fill the input in settings (dunno how to impl this UX, can be done later version)
  • sometimes cannot move the window until pressing shortcut again

issues (i can fix before release):

  • crash when using special character on shortcut (just use validator in ui input)

overall i am ready to merge, just small notes, does not have to be perfect

@tribhuwan-kumar
Copy link
Contributor

@tribhuwan-kumar curious how it behave on windows?
few (minor) weird behaviour on macos:

  • screenpipe on top of cursor (full screen cursor) when i click on minus it does not reduce (but cross does)
  • setting full screen only set 80% height somehow
  • i expected to press key and it would fill the input in settings (dunno how to impl this UX, can be done later version)
  • sometimes cannot move the window until pressing shortcut again
    issues (i can fix before release):
  • crash when using special character on shortcut (just use validator in ui input)
    overall i am ready to merge, just small notes, does not have to be perfect

let me test it on windows

@tribhuwan-kumar
Copy link
Contributor

i merge it locally with latest main branch and tested it, got some error about ActivationPolicy in windows. test.log

@louis030195 louis030195 merged commit 8d940bd into mediar-ai:main Oct 20, 2024
3 of 7 checks passed
@louis030195
Copy link
Collaborator

/approve

Copy link

algora-pbc bot commented Oct 20, 2024

@louis030195: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment.

@louis030195
Copy link
Collaborator

/tip $50 @tribhuwan-kumar

thx for testing

Copy link

algora-pbc bot commented Oct 20, 2024

🎉🎈 @tribhuwan-kumar has been awarded $50! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants