feat(tray): add start/stop recording options and global shortcut (WIP) #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 task
Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>
louis030195
reviewed
Oct 17, 2024
| last_restart: Instant, | ||
| restart_interval: Arc<Mutex<Duration>>, | ||
| restart_task: Option<JoinHandle<()>>, | ||
| dev_mode: Arc<Mutex<bool>>, | ||
| pub is_recording: bool, |
There was a problem hiding this comment.
this variable is not necessary, we just want to allow user to start or stop the sidecar with less friction than now (atm they need to go in screenpipe app and click on stop/start) we want to save them a few clicks/seconds on this
2 tasks
Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>
Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>
louis030195
reviewed
Oct 19, 2024
| let app_handle = app.handle().clone(); | ||
| let event_app_handle = app_handle.clone(); // Clone for event emission | ||
|
|
||
| match app.handle().plugin( |
There was a problem hiding this comment.
can you make this less nested? really hard to read
|
can you make the shortcut changeable in settings like done in here? #524 if too hard i can make it before release |
Yes, I thought of that too. |
|
Closing this due to conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #515
/claim #515
WIP