Misc. edits #184
Merged
Misc. edits #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hajdik
requested review from
marcomangano and
sseraj
and removed request for
a team
marcomangano
approved these changes
Feb 20, 2023
sseraj
reviewed
Feb 20, 2023
hajdik
commented
Mar 3, 2023
sseraj
added a commit
that referenced
this pull request
Jun 9, 2023
* added initial joss paper * added GHA * added some basic summary * start parametric tools section * actually commit the paper * mystery paragraph * constraints * added FFD section * constraints * whitespace * format fixes * cst * fix constraints * wording * start examples * started statement of need * added some comments * clarify esp/vsp need * Updated DVGeoCST description * esp/vsp process * expanded FFD a bit * added some short text on parallelism and gradients * added DVGeoMulti description and figure * edited ffd derivatives * comments and edits up to geometry parametrization * added description of children FFDs, to be reviewed * addressed a few marco comments * removed references to module names * esp and vsp pictures, children FFD-> child FFD * clarifying solver independence * added authors * Make global FFD DV figures nicer * Added CST figure * include cst figure, ffd figure works slightly better * trying to fix FFD DV figure * pdfs * started geometry generation section + pic * geometry generation * fix figure * orcid * captions * minor edits * orcids * josh edits (#172) * josh edits * add missed edit * minor updates to Josh edits Co-authored-by: Hannah Hajdik <hajdik@umich.edu> * Sabet JOSS paper edits (#173) * edits through FFD * finished edits and added todos * higher resolution images from papers * addressed some Sabet todos * condense parametric geometry section * talking to Sabet Co-authored-by: Hannah Hajdik <hajdik@umich.edu> * Finished my edits. Please check all my changes to make sure I did not change the meaning or introduce innacuracis. Check and respond to the TODOs. * fixed figure labels * updated multi FFD figure * minor changes * Marco's paper edits (#174) * rephrased abstract - MDO not only aerostructural * edits up to hierarchical FFD * minor fixes up to cst * some details and comments on constraints * more reprasings suggestions and commments * finalize marco edits Co-authored-by: Hannah Hajdik <hajdik@umich.edu> * added Lyu 2014 BWB paper citation * added CST derivatives * Joss paper anil's edits (#175) * anil edits * fixed footnotes * some anil todos * take out geometry generation * constraint figure --------- Co-authored-by: Sabet Seraj <48863473+sseraj@users.noreply.github.com> Co-authored-by: Hannah Hajdik <hajdik@umich.edu> * Ben B edits and additions to the paper * Misc. edits (#184) * josh edits * add missed edit * cleaning up extra detail * cropped figure for triangulated surface constraint * new figures for child ffd & trisurfcon * delete old versions of figures * removed abstracts in bib file * small edits * cleaned up some comments * neil comments * removing old TODOs * saved old sections elsewhere and deleted comments * deleted old comments * sabet todo * clarifying * fixed sabet's todo. with sabet. todone. * anil said it's fine * redid summary & statement of need with sabet --------- Co-authored-by: Josh Anibal <joanibal@umich.edu> Co-authored-by: Neil Wu <neilwu0626@gmail.com> * removed paper pdf * updated bib * move SVD reference * standardize name formats * zenodo metadata * version bump * formatting * isort again * even more sorted * comments? * another one * Finished my edits. * grammar/format * A few more edits. * A few more edits. * sabet comments * zenodo metadata * quim comments * citation and acronym fixes * citation again * remove yml --------- Co-authored-by: Neil Wu <602725+nwu63@users.noreply.github.com> Co-authored-by: eytanadler <eytana@umich.edu> Co-authored-by: Marco Mangano <mmangano@umich.edu> Co-authored-by: Alasdair Gray <alachris@umich.edu> Co-authored-by: Josh Anibal <joanibal@umich.edu> Co-authored-by: Sabet Seraj <48863473+sseraj@users.noreply.github.com> Co-authored-by: Joaquim Martins <jrram@umich.edu> Co-authored-by: Marco Mangano <36549388+marcomangano@users.noreply.github.com> Co-authored-by: Anil Yildirim <42349285+anilyil@users.noreply.github.com> Co-authored-by: Ben Brelje <benjamin.brelje@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last miscellaneous stuff I wanted to clean up on the paper.
@nwu63 check to see if this took out enough extraneous detail or let me know if there's specific parts you still want gone.
(I don't know why Josh's edits are in this but the diff looks right)