-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JOSS paper #203
Add JOSS paper #203
Conversation
Codecov Report
@@ Coverage Diff @@
## main #203 +/- ##
=======================================
Coverage 64.76% 64.76%
=======================================
Files 47 47
Lines 12018 12018
=======================================
Hits 7783 7783
Misses 4235 4235
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than two minor things. Once fixed (and required approvals are obtained) we can remove the GHA file, and merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, don't forget to make a release after merged!
Purpose
Bring the paper branch into main as the review is nearly complete. Also bump the version and add a metadata file for the zenodo build to pick up on.
Expected time until merged
A day or two so we can do a final proofread
Type of change
Testing
PDF can be viewed here
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable