fix(ssr): use different language tag when with duplicate langs #7921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked as draft to fix mdn/content#23596 (comment) |
caugner
requested changes
Feb 9, 2023
ssr/render.ts
Outdated
Comment on lines
20
to
23
| const LANGUAGE_TAGS = new Map([ | ||
| ["zh-CN", "zh-Hans"], | ||
| ["zh-TW", "zh-Hant"], | ||
| ]); |
There was a problem hiding this comment.
Can we use a simple frozen object instead, and add the region?
Suggested change
| const LANGUAGE_TAGS = new Map([ | |
| ["zh-CN", "zh-Hans"], | |
| ["zh-TW", "zh-Hant"], | |
| ]); | |
| const LANGUAGE_TAGS = Object.freeze({ | |
| 'zh-CN': 'zh-Hans-CN', | |
| 'zh-TW': 'zh-Hant-TW', | |
| }); |
There was a problem hiding this comment.
I'm not sure should we just use zh-Hans for Simplified Chinese (zh-CN) and zh-Hant for traditional Chinese (zh-TW) without the region code (CN and TW). As we are using the shortest language tags that won't be duplicated.
There was a problem hiding this comment.
You're right, using zh-Hans and zh-Hant would be consistent with using pt for pt-BR.
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
caugner
reviewed
Feb 16, 2023
caugner
reviewed
Feb 16, 2023
caugner
reviewed
Feb 16, 2023
caugner
reviewed
Feb 16, 2023
caugner
reviewed
Feb 16, 2023
caugner
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Tested locally (yarn dev and looked at the source of http://localhost:5042/en-US/docs/Learn/HTML), and works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See the result of hreflang tag testing tool on https://developer.mozilla.org/zh-CN/docs/Web/JavaScript/Reference/Global_Objects/Array:
Problem
lang-regionis not prefered now, we may switch tolang-scriptformat now. (as a part of <html> lang attribute "zh-CN", "zh-TW" does not conform BCP 47 Language Subtag Registry content#23596)Solution
To resolve this, we should also include zh-CN locale when try to resolve language tag for zh-TW.
Screenshots
Before
See problem description.
After
See testing.
How did you test this change?
run
yarn test:testing