Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<html> lang attribute "zh-CN", "zh-TW" does not conform BCP 47 Language Subtag Registry #23596

Closed
winstonsung opened this issue Jan 13, 2023 · 8 comments
Closed

<html> lang attribute "zh-CN", "zh-TW" does not conform BCP 47 Language Subtag Registry #23596

winstonsung opened this issue Jan 13, 2023 · 8 comments
Labels
Content:Other Any docs not covered by another "Content:" label

Comments

@winstonsung
Copy link
Contributor

winstonsung commented Jan 13, 2023 •
edited
Loading

MDN URL

What specific section or headline is this issue about?

<html lang="*"

What information was incorrect, unhelpful, or incomplete?

  • <html lang="zh-CN"
  • <html lang="zh-TW"

What did you expect to see?

  • <html lang="zh-Hans-CN"
  • <html lang="zh-Hant-TW"

Do you have any supporting links, references, or citations?

Do you have anything more you want to share?
@winstonsung winstonsung added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jan 13, 2023
@winstonsung winstonsung changed the title <html> lang attribute "zh-CN", "zh-TW" does not conform <html> lang attribute "zh-CN", "zh-TW" does not conform BCP 47 Language Subtag Registry Jan 13, 2023
@yin1999
Copy link
Member

yin1999 commented Jan 13, 2023 •
edited
Loading

This is the issue of the yari platform. @sideshowbarker, could you transfer this to there.

I'd like to deal with this in mdn/yari#7921. (used to correct the language tag, I'll fix a part of this)

Never mind. This should related to mdn/yari#6282.

@sideshowbarker
Copy link
Collaborator

Never mind. This should related to mdn/yari#6282.

So are you saying we should still also keep this mdn/content issue open?

@yin1999
Copy link
Member

yin1999 commented Jan 13, 2023

So are you saying we should still also keep this mdn/content issue open?

Yes. IMO, we still need to correct the language tags: use zh-Hant-TW or zh-Hant for locale zh-TW.

@yin1999 yin1999 mentioned this issue Jan 13, 2023
Merged
@sideshowbarker sideshowbarker added Content:Other Any docs not covered by another "Content:" label and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jan 14, 2023
@yin1999
Copy link
Member

yin1999 commented Feb 16, 2023 •
edited
Loading

we still need to correct the language tags: use zh-Hant-TW or zh-Hant for locale zh-TW.

resolved in mdn/yari#7921.

We will get zh tag for zh-CN and zh-Hant tag for zh-TW after the next deployment.

@wbamberg
Copy link
Collaborator

@yin1999 , I'm a bit confused, can we close this now?

@yin1999
Copy link
Member

yin1999 commented Mar 23, 2023

@yin1999 , I'm a bit confused, can we close this now?

I think we could. As the lang attribute has been replaced and the localization of landing page is only the platform issue (mdn/yari#6282).

@winstonsung
Copy link
Contributor Author

winstonsung commented Mar 29, 2023 •
edited
Loading

@yin1999

It seems the issue has been misunderstood.

This issue is for <html lang attribute instead of <link hreflang .

@yin1999
Copy link
Member

yin1999 commented Mar 29, 2023

It seems the issue has been misunderstood.

This issue is for <html lang attribute instead of <link hreflang .

Oh yes, sorry. I would create another PR to fix this. Thanks for the note :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Content:Other Any docs not covered by another "Content:" label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sideshowbarker @wbamberg @yin1999 @winstonsung