Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caveat for spl case dominator in “Dominators” doc #8903

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Caveat for spl case dominator in “Dominators” doc #8903

merged 1 commit into from
Sep 15, 2021

Conversation

himanshugarg
Copy link
Contributor

@himanshugarg himanshugarg commented Sep 14, 2021 •
edited
Loading

Issue number that this PR fixes (if any). For example: 'Fixes #987654321'

Fixes #3346

What was wrong/why is this fix needed? (quick summary only)

The example of a subtle case doesn't capture a subtlety. See bug desc.

Anything else that could help us review it

I have edited based on just acquired common-sense understanding of the topic.

@himanshugarg himanshugarg requested a review from a team as a code owner September 14, 2021 12:44
@himanshugarg himanshugarg requested review from teoli2003 and removed request for a team September 14, 2021 12:44
@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Tools/Memory/Dominators
Title: Dominators
on GitHub

No new external URLs

@teoli2003 teoli2003 removed their request for review September 14, 2021 12:46
@sideshowbarker sideshowbarker changed the title Fixes #3346 - Caveat for spl case dominator Caveat for spl case dominator in “Dominators” doc Sep 15, 2021
@sideshowbarker sideshowbarker merged commit 235e7e9 into mdn:main Sep 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with "Dominators": Wrong description of dominator relationship
2 participants
@himanshugarg @sideshowbarker