Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with "Dominators": Wrong description of dominator relationship #3346

Closed
SamZhangQingChuan opened this issue Mar 22, 2021 · 0 comments · Fixed by #8903
Closed

Issue with "Dominators": Wrong description of dominator relationship #3346

SamZhangQingChuan opened this issue Mar 22, 2021 · 0 comments · Fixed by #8903
Labels
Content:DevTools Firefox DevTools docs (retired) needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@SamZhangQingChuan
Copy link

SamZhangQingChuan commented Mar 22, 2021 •
edited by sideshowbarker
Loading

MDN URL: https://developer.mozilla.org/en-US/docs/Tools/Memory/Dominators

What information was incorrect, unhelpful, or incomplete?

One slight subtlety here is that if an object A is referenced by two other objects B and C, then neither object is its dominator

This is not necessarily true. Consider the graph [B->A,B->C,C->A].

Specific section or headline?

Dominators

What did you expect to see?

Did you test this? If so, how?

MDN Content page report details
@chrisdavidmills chrisdavidmills added Content:DevTools Firefox DevTools docs (retired) needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Mar 22, 2021
@SamZhangQingChuan SamZhangQingChuan changed the title Issue with "Dominators": (short summary here please) Issue with "Dominators": Wrong description of dominator relationship Mar 30, 2021
himanshugarg pushed a commit to himanshugarg/content that referenced this issue Sep 14, 2021
Fixes mdn#3346 - Caveat for spl case dominator
2e3f29c
@himanshugarg himanshugarg mentioned this issue Sep 14, 2021
Merged
sideshowbarker pushed a commit that referenced this issue Sep 15, 2021
Caveat for spl case dominator in “Dominators” doc (#8903)
235e7e9 
Fixes #3346
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Content:DevTools Firefox DevTools docs (retired) needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Caveat for spl case dominator in “Dominators” doc himanshugarg/content
2 participants
@chrisdavidmills @SamZhangQingChuan