Remove reference to mode: "websocket" in RequestInit
#36200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In https://fetch.spec.whatwg.org/#request-class, there's an explicit note that this value is excluded from the `RequestMode` enum as it's not intended to be observable from JS.
dead-claudia
requested review from
sideshowbarker
and removed request for
a team
github-actions
bot
added
Content:WebAPI
|
Preview URLs |
wbamberg
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Title's self-explanatory
Motivation
In https://fetch.spec.whatwg.org/#request-class, there's an explicit note that this value is excluded from the
RequestModeenum as it's not intended to be observable from JS.Additional details
I was working on my spec suggestion in whatwg/websockets#16 (comment), was going through you to a relevant section of the
fetchspec, and was surprised the mode existed. I then cross-referenced the spec with you all, and found that your listing of that mode was erroneous.Related issues and pull requests