Improve documentation for no-cors mode #36476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35488.
The immediate thing here is that you can't set
Range
when making ano-cors
request, even thoughRange
is a CORS-safelisted request header. So everywhere that we said "with no-cors, you can only set CORS-safelisted request headers" needed to be updated.I didn't want to duplicate these details too much and wasn't sure where to put them. There are three pages I could see that needed updating:
I ended up putting most of the details in
RequestInit
, because that's the point where you setmode
, and because you're more likely to get to that page from (especially) the service worker documentation.Request.mode
is just a read-only reflection of the value set inRequestInit
.I also tried to update
no-cors
to explain what it actually does, what the implications of using it are (especially, what an opaque response is), and when you might want to use it. It seems like a lot of people are confused about it, thinking it's a way to get around CORS errors, which it really isn't.Sources: