-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert noteblock in /games
to GFM syntax
#33575
Conversation
Hi @queengooborg, sorry the delay, I'm getting to this only now. I've just gone through the related PRs and threads, and it seems we're waiting for some decision in the other yari PR you've opened: mdn/yari#11108. As an aside, I noticed this PR uses |
3134803
to
edc1750
Compare
Good catch, thanks -- I had a typo in my converter script! This is really waiting for a bugfix, not a decision, but the bugfix is now blocked by a decision apparently... |
This pull request has merge conflicts that must be resolved before it can be merged. |
This is now unblocked :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @queengooborg 👍, approving.
I can merge after the conflicts are resolved
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
> [!NOTE] | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should review this after new Yari is used in preview, because currently this still appears broken
This PR replaces all of the old noteblock syntax with GFM syntax, using a script I wrote. This performs the migration for the
/games
folder.