Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert noteblock in /games to GFM syntax #33575

Merged
merged 6 commits into from
Jul 23, 2024
Merged

Convert noteblock in /games to GFM syntax #33575

merged 6 commits into from
Jul 23, 2024

Conversation

queengooborg
Copy link
Collaborator

This PR replaces all of the old noteblock syntax with GFM syntax, using a script I wrote. This performs the migration for the /games folder.

@queengooborg queengooborg requested a review from a team as a code owner May 13, 2024 03:24
@queengooborg queengooborg requested review from dipikabh and removed request for a team May 13, 2024 03:24
@github-actions github-actions bot added Content:Games Games docs size/m [PR only] 51-500 LoC changed labels May 13, 2024
Copy link
Contributor

github-actions bot commented May 13, 2024

Preview URLs (37 pages)
Flaws (2)

Note! 36 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Games/Tutorials/HTML5_Gamedev_Phaser_Device_Orientation
Title: 2D maze game with device orientation
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/Apps/Fundamentals/gather_and_modify_data/responding_to_device_orientation_changes
    • Can't resolve /en-US/docs/Web/Apps/Fundamentals/gather_and_modify_data/responding_to_device_orientation_changes
External URLs (20)

URL: /en-US/docs/Games/Tutorials/2D_breakout_game_Phaser
Title: 2D breakout game using Phaser


URL: /en-US/docs/Games/Tutorials/2D_Breakout_game_pure_JavaScript
Title: 2D breakout game using pure JavaScript


URL: /en-US/docs/Games/Tutorials/HTML5_Gamedev_Phaser_Device_Orientation
Title: 2D maze game with device orientation


URL: /en-US/docs/Games/Tools/asm.js
Title: asm.js


URL: /en-US/docs/Games/Techniques/Audio_for_Web_Games
Title: Audio for Web games


URL: /en-US/docs/Games/Techniques/Tilemaps
Title: Tiles and tilemaps overview


URL: /en-US/docs/Games/Techniques/Control_mechanisms/Desktop_with_mouse_and_keyboard
Title: Desktop mouse and keyboard controls


URL: /en-US/docs/Games/Techniques/Control_mechanisms/Mobile_touch
Title: Mobile touch controls


URL: /en-US/docs/Games/Techniques/2D_collision_detection
Title: 2D collision detection


URL: /en-US/docs/Games/Techniques/3D_on_the_web/Building_up_a_basic_demo_with_Three.js
Title: Building up a basic demo with Three.js


URL: /en-US/docs/Games/Techniques/3D_on_the_web/Building_up_a_basic_demo_with_PlayCanvas
Title: Building up a basic demo with PlayCanvas


URL: /en-US/docs/Games/Techniques/3D_on_the_web/Building_up_a_basic_demo_with_A-Frame
Title: Building up a basic demo with A-Frame

(comment last updated: 2024-07-23 11:48:57)

@dipikabh
Copy link
Contributor

Hi @queengooborg, sorry the delay, I'm getting to this only now. I've just gone through the related PRs and threads, and it seems we're waiting for some decision in the other yari PR you've opened: mdn/yari#11108.

As an aside, I noticed this PR uses ![NOTE]. Shouldn't these be [!NOTE]?

@queengooborg
Copy link
Collaborator Author

As an aside, I noticed this PR uses ![NOTE]. Shouldn't these be [!NOTE]?

Good catch, thanks -- I had a typo in my converter script!


This is really waiting for a bugfix, not a decision, but the bugfix is now blocked by a decision apparently...

Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Jun 14, 2024
@Josh-Cena
Copy link
Member

This is now unblocked :)

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @queengooborg 👍, approving.
I can merge after the conflicts are resolved

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Jul 20, 2024
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Comment on lines +36 to +37
> [!NOTE]
>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should review this after new Yari is used in preview, because currently this still appears broken

@dipikabh dipikabh dismissed their stale review July 23, 2024 11:47

dismissing the two comments

@dipikabh dipikabh merged commit b0d4232 into main Jul 23, 2024
9 checks passed
@dipikabh dipikabh deleted the gfm-conversion/games branch July 23, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Games Games docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants