fixed image background #29698
Merged
fixed image background #29698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed background color for images which was unreadable in dark theme.
|
Taking a look 👀 |
bsmth
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Thanks a lot for this one. I think this is reasonable for these images (also with the compression / space saving).
We should follow-up and check for others as I'm sure we have transparent pngs elsewhere in the content that will need this treatment (and ideally be converted to SVG).
Thanks for your fix! 🙌🏻
|
Actually I didn't wanted to change the format so I just added white background to the png images. If I find other images with similar issue can I fix them similar to these? and make a PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed background color for images which was unreadable in dark theme.
Description
The images in the following url were not readable in dark theme:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Content_negotiation#principles_of_content_negotiation
I have added white background to all the images and is readable now.
Motivation
I came across this issue in the issues tab for the repository #29644
therefore I solved the issue
Additional details
Initial image:
Fixed Image:
Related issues and pull requests
Fixes #29644