Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transparent images unreadable in dark theme. #29644

Closed
zjffun opened this issue Oct 15, 2023 · 0 comments · Fixed by #29698
Closed

Transparent images unreadable in dark theme. #29644

zjffun opened this issue Oct 15, 2023 · 0 comments · Fixed by #29698
Labels
Content:HTTP HTTP docs

Comments

@zjffun
Copy link
Contributor

zjffun commented Oct 15, 2023 •
edited
Loading

MDN URL

https://developer.mozilla.org/en-US/docs/Web/HTTP/Content_negotiation#principles_of_content_negotiation

What specific section or headline is this issue about?

principles_of_content_negotiation

What information was incorrect, unhelpful, or incomplete?

Texts in images unreadable.

image

What did you expect to see?

Texts in images readable.

Screen Shot 2023-10-15 at 10 24 57

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

It looks like we can't crudely set the background of all images to #fff. Could we set a background for individual images? Or change the httpnego.png to opaque?

History issue about images background:

#27241
mdn/yari#9130
mdn/yari#9250

Current style of those images:

https://github.com/mdn/yari/blob/main/client/src/document/index.scss#L85-L93
@zjffun zjffun added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Oct 15, 2023
@github-actions github-actions bot added the Content:HTTP HTTP docs label Oct 15, 2023
@Sentious Sentious mentioned this issue Oct 18, 2023
Merged
@bsmth bsmth removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Content:HTTP HTTP docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed image background Sentious/content
2 participants
@zjffun @bsmth