Time based forking #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberto-bayardo
force-pushed
the
time-based-forking
branch
8 times, most recently
from
9b475e3
to
d1e3846
Compare
|
I think this is ready for review now. This builds on the commits from ethereum#25878 |
Inphi
reviewed
Dec 5, 2022
roberto-bayardo
force-pushed
the
time-based-forking
branch
from
d1e3846
to
dac0e11
Compare
Inphi
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not quite done but sending this out for some early feedback. The issue I'd like some feedback on is how "MakeSigner" now appears to need the block time, not just the block number, and this is quite pervasive a change. Maybe there's a better way here?
cc: @MariusVanDerWijden