params: core: enable shanghai based on timestamps #25878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusVanDerWijden
requested review from
s1na,
karalabe,
holiman and
rjl493456442
as code owners
lightclient
reviewed
Nov 6, 2022
params/config.go
Outdated
| func (c *ChainConfig) IsShanghai(num *big.Int) bool { | ||
| return isForked(c.ShanghaiBlock, num) | ||
| // IsShanghai returns whether time is either equal to the Shanghai fork time or greater. | ||
| func (c *ChainConfig) IsShanghai(time *big.Int) bool { |
There was a problem hiding this comment.
Suggested change
| func (c *ChainConfig) IsShanghai(time *big.Int) bool { | |
| func (c *ChainConfig) IsShanghai(time uint64) bool { |
It would be nice if either this took a uint64 or if we don't want IsShanghai to take a different parameter type than other isForked methods, maybe a new getter on types.Block and types.Header "TimeBig()" so that each time we check IsShanghai, don't need to jump through a bunch of casting hoops?
There was a problem hiding this comment.
It might be better to have a different type here to detect at compile time if someone is trying to pass in a block number instead of a timestamp. e.g. there are calls to IsShanghai() in the withdrawals PR and EIP-4844 repo that would need to be updated but would not be flagged by the compiler.
karalabe
force-pushed
the
shanghai-by-time
branch
from
2d85996
to
1cd8782
Compare
yperbasis
added a commit
to erigontech/erigon
that referenced
this pull request
Dec 16, 2022
Starting from [Shanghai](https://github.com/ethereum/execution-specs/blob/master/network-upgrades/mainnet-upgrades/shanghai.md), forks are based on timestamps rather than block heights (see PR #6238). This PR extends [EIP-2124](https://eips.ethereum.org/EIPS/eip-2124) Fork ID to include timestamp-based blocks. See also ethereum/go-ethereum#25878. Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>
|
Forkid filtering is broken in this pr, needs MariusVanDerWijden#42 |
karalabe
force-pushed
the
shanghai-by-time
branch
from
495ffd7
to
a2d3873
Compare
karalabe
force-pushed
the
shanghai-by-time
branch
2 times, most recently
from
1bbb82c
to
ca4002e
Compare
karalabe
approved these changes
Jan 4, 2023
lightclient
reviewed
Jan 4, 2023
rjl493456442
reviewed
Jan 5, 2023
rjl493456442
reviewed
Jan 5, 2023
rjl493456442
reviewed
Jan 5, 2023
rjl493456442
reviewed
Jan 5, 2023
rjl493456442
reviewed
Jan 5, 2023
holiman
reviewed
Jan 5, 2023
karalabe
force-pushed
the
shanghai-by-time
branch
from
ca4002e
to
3669ca6
Compare
rjl493456442
approved these changes
Jan 6, 2023
karalabe
force-pushed
the
shanghai-by-time
branch
from
3669ca6
to
754f1b0
Compare
karalabe
force-pushed
the
shanghai-by-time
branch
from
ae1330d
to
b56c796
Compare
Rjected
added a commit
to Rjected/ethers-rs
that referenced
this pull request
Jan 12, 2023
* geth switched to time-based forking in ethereum/go-ethereum#25878, this changes the name of the `shanghai_block` field to `shanghaiTime` so it is compatible with geth.
Rjected
added a commit
to Rjected/ethers-rs
that referenced
this pull request
Jan 12, 2023
* geth switched to time-based forking in ethereum/go-ethereum#25878, this changes the name of the `shanghai_block` field to `shanghaiTime` so it is compatible with geth.
4 tasks
gakonst
pushed a commit
to gakonst/ethers-rs
that referenced
this pull request
Jan 13, 2023
* geth switched to time-based forking in ethereum/go-ethereum#25878, this changes the name of the `shanghai_block` field to `shanghaiTime` so it is compatible with geth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes Shanghai activation to be based on timestamps instead of block numbers