feat(ingest): add powerbi plugin #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurinehate
commented
Feb 4, 2022
metadata-ingestion/setup.py
Outdated
| @@ -91,6 +91,9 @@ def get_long_description(): | |||
| "cryptography==3.4.8" | |||
| } | |||
|
|
|||
| powerbi_common = { | |||
There was a problem hiding this comment.
Do we need this separate powerbi_common dictionary ? I don't see it being used anywhere except powerbi plugin. If you foresee that the same dependencies would be present for any other plugins, we can keep it. (probably name it microsoft_common in that case?)
| # First convert tiles to charts | ||
| ds_mcps, chart_mcps = self.to_datahub_chart(dashboard.tiles) | ||
| # Lets convert dashboard to datahub dashboard | ||
| dashboard_mcps = self.__to_datahub_dashboard(dashboard, chart_mcps) |
There was a problem hiding this comment.
Can we follow some naming convention ? e.g. self.to_datahub_chart and self.__to_datahub_dashboard should follow similar naming convention if they have same privacy level(leading underscores).
| @@ -0,0 +1,173 @@ | |||
| [ | |||
There was a problem hiding this comment.
Is this file being used ?
|
Please add documentation for the powerbi source. |
mayurinehate
pushed a commit
that referenced
this pull request
Jun 14, 2022
Oss salesforce connector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist