Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: powerbi source plugin #4201

Merged
merged 28 commits into from
Mar 1, 2022
Merged

feat: powerbi source plugin #4201

merged 28 commits into from
Mar 1, 2022

Conversation

siddiquebagwan
Copy link
Contributor

powerbi source for Datahub "data platform"

@siddiquebagwan siddiquebagwan changed the title powerbi source feat: powerbi source plugin Feb 21, 2022
@github-actions
Copy link

github-actions bot commented Feb 23, 2022

Unit Test Results (build & test)

  71 files  +  1    71 suites  +1   12m 9s ⏱️ + 6m 2s
618 tests +77  559 ✔️ +70  59 💤 +7  0 ±0 

Results for commit f653fa5. ± Comparison against base commit a113e43.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 23, 2022

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   46m 36s ⏱️ + 2m 26s
   343 tests +1     343 ✔️ +1    0 💤 ±0  0 ±0 
1 562 runs  +5  1 531 ✔️ +5  31 💤 ±0  0 ±0 

Results for commit f653fa5. ± Comparison against base commit a113e43.

♻️ This comment has been updated with latest results.

@siddiquebagwan
Copy link
Contributor Author

Hi @shirshanka
I updated the code as per review comments.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit e2f8db7 into datahub-project:master Mar 1, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants