Rebase from gwastro #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial checkin/structure for live pastro * cc * fix class name * improve importability by putting matplotlib inside functions * More skeleton work for live pastro * fix import * cc, fix attr namex * line cont typo * move mpl import into functions * reorg & horizon factor in p astro * get template info, padata optional * fix variables, cc * return p astro and p terr * output stuff for live pastro * typos * simple approx p astro expression * sphinx fix attempt * fix return tuple * slight CC appeasement * first working version * better standardize pastro file names * lots of logging * CC niggle * few docstrings * replacing messy replace()s * fix syntax * dict comprehension formatting * CC niggle, remove commented lines & print statement * Pass option values rather than full args object * get all the horizons! * remove args fully from padata setup, simplify do/not-do * fix verify * TDC suggestions * Change logic to save and upload minimum # of files * don't return nothing, return None * None not necessary * Use actual name of p astro file * Less verbose logging info * fix logging * simplify input and checking * with bank * fix __all__ * fixes * fixes, exception plumbing * use attribute not global variable
* Update install_lalsuite.rst * Update install_lalsuite.rst
* Use class-based API in StrainBuffer - PART 1 * Fixes to previous * FIx to previous * Attempt to move other block to strain API * Add cache-based class-based FFTs in resample and strain * Pycbc live to use cached FFTs * Some fixes to previous * CodeClimating * Some reordering as per discussion on PR * Typo * Various fixes * Remove additional complication that isn't needed * Significant rework of cached_FFT * Some clean up * More cleanup * Code climating * Add UIDs as constants * Copy output by default
* Rationalize upload options "Nothing should be uploaded to gracedb without the --enable-gracedb-upload option." * fix space typo * Actually fix typo * Group ifar/back est options together
* Reorganize APIs related to GraceDB uploads * Fix
* Update Docker files * Also update venv * Also thie file * Probably don't want python38-devel for python39
* Simplify methods of LiveEventManager * Restructure constructor of LiveEventManager * Forgot this
Only initialize p_astro for the root process, and do print p_astro details at initialization when `--verbose` is used.
* Move test files to pycbc-config * Move more data files to pycbc_config * Remove one more block of files * Finish removing data directory * Update test/test_skymax.py Co-authored-by: Tito Dal Canton <tito@dalcanton.it> * Update test/test_skymax.py Co-authored-by: Tito Dal Canton <tito@dalcanton.it> * Update test/test_skymax.py Co-authored-by: Tito Dal Canton <tito@dalcanton.it> * Update test_skymax.py * Update test_tmpltbank.py Co-authored-by: Alex Nitz <alex.nitz@gmail.com> Co-authored-by: Tito Dal Canton <tito@dalcanton.it>
* Implement "don't always recompute PSD" option * Add caching functions in estimate as well * Fix typo in pycbc_live * Add more caching to pycbc_live front end * Add in the new option * FFT - Fix for cached fft/ifft * Codeclimating * Add positive_int type as requested * Line spacing * Enforce positive_int * Need to actually return object * Update bin/pycbc_live Co-authored-by: Tito Dal Canton <tito@dalcanton.it> * Update optparse.py Co-authored-by: Tito Dal Canton <tito@dalcanton.it>
* Fix bug in PyCBC Live background estimate * DOc additions and Tom-suggested changes * Typo * Typo * WS removal * IFO might not be online * Rename ifos to valid_ifos * Rewriting some comments, docstrings etc. * minor comment fix * CC and a typo fix Co-authored-by: Thomas Dent <thomas.dent@usc.es>
* what happens here * Why was this here? * fix
* fix waveform_transforms not defined issue * add static_args back * fix cc issues
* Attempt to make faster ring buffer * Try to fix RingBuffer * RingBuffer - Don't add a 0 entry * RingBuffer: Hopefullly working now * Codeclimating * Some more corrections * Add new unittest * Adjust unittest to ensure resizing happens * Download stat files when needed * Need FAR fix in validation code * Changes suggested by Tito * More comments from Tito * Update test/test_live_coinc_compare.py Co-authored-by: Tito Dal Canton <tito@dalcanton.it> Co-authored-by: Tito Dal Canton <tito@dalcanton.it>
* First approach to no-mass-gap as default option * Change if loops * Remove double argument for MAX_NS and change help * Add missing argument for calc_areas * Sort mass limits * small formatting * Added parser error if MAX_GAP < MAX_NS * Undo last commit * Passing parser to mchirp_area.from_cli() function * Added parser error if MAX_GAP < MAX_NS * CC line lengths Co-authored-by: Thomas Dent <thomas.dent@usc.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update with commits from gwastro