Speed up psd computation for PyCBC Live #4106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any comments on this one? This PR only makes changes that affects pycbc_live, and is basically just an addition to what was done in #4096 |
titodalcanton
approved these changes
Aug 30, 2022
Co-authored-by: Tito Dal Canton <tito@dalcanton.it>
connor-mcisaac
pushed a commit
to connor-mcisaac/pycbc
that referenced
this pull request
Oct 12, 2022
* Implement "don't always recompute PSD" option * Add caching functions in estimate as well * Fix typo in pycbc_live * Add more caching to pycbc_live front end * Add in the new option * FFT - Fix for cached fft/ifft * Codeclimating * Add positive_int type as requested * Line spacing * Enforce positive_int * Need to actually return object * Update bin/pycbc_live Co-authored-by: Tito Dal Canton <tito@dalcanton.it> * Update optparse.py Co-authored-by: Tito Dal Canton <tito@dalcanton.it>
acorreia61201
pushed a commit
to acorreia61201/pycbc
that referenced
this pull request
Apr 4, 2024
* Implement "don't always recompute PSD" option * Add caching functions in estimate as well * Fix typo in pycbc_live * Add more caching to pycbc_live front end * Add in the new option * FFT - Fix for cached fft/ifft * Codeclimating * Add positive_int type as requested * Line spacing * Enforce positive_int * Need to actually return object * Update bin/pycbc_live Co-authored-by: Tito Dal Canton <tito@dalcanton.it> * Update optparse.py Co-authored-by: Tito Dal Canton <tito@dalcanton.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more patch to try to help with
pycbc_liveperformance:This one moves the FFTs in PSD estimation (done during inverse spectrum truncation), to the new
cached_fftfunctions.I also add an option to allow the PSD not to be recomputed every data block. For the early warning analysis, with 1 second blocks, this is especially relevant. I have set this such that if the data is "bad" the PSD must be recomputed as soon as it is "good" again. (It's still not entirely clear to me what data is used for PSD estimation, and if we should continue computing PSDs until we have X data blocks in the buffer, and then only recompute every Y data blocks).