Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ftp: use call_user_callback #2230

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Ftp: use call_user_callback #2230

merged 1 commit into from
Feb 22, 2024

Conversation

chep
Copy link
Contributor

@chep chep commented Feb 22, 2024

I experienced dead locks while calling ftp functions inside ftp callback. For example, I was trying to start a download while in are_files_identical_async callback.
Currently, only list_directory_async is using call_user_callback since commit 50c2301

JonasVautherin
JonasVautherin approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that makes sense!

julianoes
julianoes approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@julianoes julianoes merged commit d88e912 into mavlink:main Feb 22, 2024
27 checks passed
@chep chep deleted the chep/ftp branch February 23, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianoes julianoes julianoes approved these changes

@JonasVautherin JonasVautherin JonasVautherin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chep @julianoes @JonasVautherin