Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTP: Set size in message on read #1709

Merged
merged 1 commit into from
Mar 3, 2022
Merged

FTP: Set size in message on read #1709

merged 1 commit into from
Mar 3, 2022

Conversation

ThomasDebrunner
Copy link
Contributor

@ThomasDebrunner ThomasDebrunner commented Mar 2, 2022 •
edited
Loading

Since PX4/PX4-Autopilot#18704, sending a 0 length on download does not make PX4 send any data.
The download gets stuck then.

This just always requests the maximum number of bytes, except for the last packet.

@TSC21 TSC21 requested a review from julianoes March 2, 2022 16:58
@julianoes julianoes force-pushed the ftp-set-size-on-read-upstream branch from 801b644 to d3cc519 Compare March 3, 2022 20:28
julianoes
julianoes approved these changes Mar 3, 2022
View reviewed changes
Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And I fixed style so it should be good to go.

@julianoes julianoes merged commit cc0896a into mavlink:main Mar 3, 2022
@julianoes julianoes added the bug label Mar 3, 2022
@ThomasDebrunner ThomasDebrunner mentioned this pull request Mar 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianoes julianoes julianoes approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasDebrunner @julianoes