Add component information client and server #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
force-pushed
the
pr-component-information-server
branch
2 times, most recently
from
f0e481a
to
31c5fcb
Compare
JonasVautherin
previously approved these changes
Jan 4, 2022
julianoes
force-pushed
the
pr-component-information-server
branch
2 times, most recently
from
121dbab
to
1199346
Compare
JonasVautherin
previously approved these changes
Jan 6, 2022
julianoes
force-pushed
the
pr-component-information-server
branch
2 times, most recently
from
ca6f366
to
a71e779
Compare
JonasVautherin
previously approved these changes
Feb 14, 2022
julianoes
force-pushed
the
pr-component-information-server
branch
from
77b1081
to
4b76fb1
Compare
julianoes
force-pushed
the
pr-component-information-server
branch
2 times, most recently
from
dd99a8a
to
eddbd5e
Compare
julianoes
changed the title
This allows us to re-use it.
This was straight forward and long overdue.
And use it in ping as well as offboard plugin.
That way we can re-use it in the component information server plugin.
I don't think it is really possible to use the REQUEST_MESSAGE command without a target_component set. If we were to send out REQUEST_MESSAGE with target_component set to 0 (broadcast) it would open up a race between various components that do support it or don't support it. All of these would respond and it would be tricky to know how to handle all the acks. Therefore, I decided to send out these REQUEST_MESSAGE commands with a target instead. This means that in component_information we will ultimately have to go through all connected components one by one to figure out what is there.
Found using valgrind.
Every 1% is enough, otherwise we just clog everything with callbacks.
This is a first step to enable downloading the component_information xml files end to end.
Just for convenience.
This is required for GCC 7 compatibility.
julianoes
force-pushed
the
pr-component-information-server
branch
from
1f2a222
to
ab2930b
Compare
julianoes
force-pushed
the
pr-component-information-server
branch
from
abad2f4
to
085815b
Compare
julianoes
force-pushed
the
pr-component-information-server
branch
from
085815b
to
90e4558
Compare
Now that the component information changes have been merged.
|
I think this is somewhat contained and should not be interfering with the rest too much, so I'm merging it as in its current prototype state. I'm not sure why CI takes so long and times out. 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on mavlink/MAVSDK-Proto#270.
Probably best reviewed commit by commit.