Skip to content

Commit

Permalink
[release-v0.17.2] Backport of upstream PR 4460 (knative#949)
Browse files Browse the repository at this point in the history
* Reimplementing fetching of wathola report with K8s job

This change targets the problem of how to get report from cluster.
Clusters may have different networking setup, and it might not be
possible to directly make HTTP request from outside of cluster.

Previous approach used to guess an external address of cluster. That for
sure fails on OpenShift deployed on AWS.

This approach deploys a special Job that, being inside cluster, can
download a report and print it in it's logs. Then test client can fetch
logs of completed job, and parse it, replay the logs, and process report
further.

Removal of unneeded external node address package

* wathola-fetcher test image

* Adding a tip of how to override openshift/release repo location
  • Loading branch information
cardil authored Nov 5, 2020
1 parent fdcd81d commit ae05db1
Show file tree
Hide file tree
Showing 18 changed files with 485 additions and 455 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ TEST=
IMAGE=

# Guess location of openshift/release repo. NOTE: override this if it is not correct.
# TIP: https://stackoverflow.com/a/29434812/844449
OPENSHIFT=${CURDIR}/../../github.com/openshift/release

install:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Do not edit! This file was generated via Makefile
FROM openshift/origin-base

ADD wathola-fetcher /usr/bin/wathola-fetcher
ENTRYPOINT ["/usr/bin/wathola-fetcher"]
68 changes: 0 additions & 68 deletions test/lib/nodes/address.go

This file was deleted.

79 changes: 0 additions & 79 deletions test/lib/nodes/address_test.go

This file was deleted.

47 changes: 0 additions & 47 deletions test/lib/nodes/kind.go

This file was deleted.

32 changes: 0 additions & 32 deletions test/lib/nodes/logger_test.go

This file was deleted.

69 changes: 0 additions & 69 deletions test/lib/nodes/nodes.go

This file was deleted.

Loading

0 comments on commit ae05db1

Please sign in to comment.