Trigger Reply Tracing #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/XL
knative-prow-robot
added
the
approved
|
The following is the coverage report on pkg/.
|
vaikas
reviewed
Mar 22, 2019
| for n, v := range tctx.Header { | ||
| lower := strings.ToLower(n) | ||
| if forwardHeaders.Has(lower) { | ||
| sendingCTX = addHeader(sendingCTX, n, v) | ||
| h[n] = v |
There was a problem hiding this comment.
Why not use the h.Add here?
There was a problem hiding this comment.
h.Add only works with an individual string and value is []string. Using h.Add, I would need to do a for loop:
for _, iv := range v {
h.Add(n, iv)
}| continue | ||
| } | ||
| for _, prefix := range forwardPrefixes { | ||
| if strings.HasPrefix(lower, prefix) { | ||
| sendingCTX = addHeader(sendingCTX, n, v) | ||
| h[n] = v |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Harwayne, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
matzew
pushed a commit
to matzew/eventing
that referenced
this pull request
Nov 5, 2020
* Reimplementing fetching of wathola report with K8s job This change targets the problem of how to get report from cluster. Clusters may have different networking setup, and it might not be possible to directly make HTTP request from outside of cluster. Previous approach used to guess an external address of cluster. That for sure fails on OpenShift deployed on AWS. This approach deploys a special Job that, being inside cluster, can download a report and print it in it's logs. Then test client can fetch logs of completed job, and parse it, replay the logs, and process report further. Removal of unneeded external node address package * wathola-fetcher test image * Adding a tip of how to override openshift/release repo location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Release Note