Update GitHub workflow to use Windows 2022 #2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mattermost-main
chenilim
requested review from
wiggin77 and
harshilsharma63
and removed request for
a team
|
Meant this to be a draft. I updated .NET to 4.8 (from 4.7) to see if that fixes the Windows 2022 dependencies. |
chenilim
changed the title
|
Ok, after updating the Windows 10 SDK path, this passes the GitHub build with the Windows Server 2022 image. The new requirements are: .NET 4.8 and Windows 10 SDK 10.0.19041.0 (added to readme). |
|
@chenilim does this affect the OS/system requirements for running the Boards desktop app? |
|
@harshilsharma63, yes .NET 4.8 is now required (up from 4.7.2). Documentation. However, the Windows SDK itself doesn't affect the version of Windows required (as long as new APIs aren't used). |
wiggin77
reviewed
Feb 16, 2022
wiggin77
approved these changes
Feb 16, 2022
sbishel
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use windows-22 for GitHub build