Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2346. Revert to Windows 2019 for GitHub actions #2347

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Fix #2346. Revert to Windows 2019 for GitHub actions #2347

merged 1 commit into from
Feb 15, 2022

Conversation

chenilim
Copy link
Contributor

Summary

Revert to use the Windows 2019 image for GitHub builds for now. Note that windows-latest just changed to Server 2022, which caused this build break.

Ticket Link

#2346

@chenilim chenilim requested a review from a team as a code owner February 15, 2022 20:22
@chenilim chenilim requested review from wiggin77, harshilsharma63 and sbishel and removed request for a team February 15, 2022 20:22
@chenilim
Copy link
Contributor Author

GitHub just updated the windows-latest image to use Server 2022, which caused this build break.

@chenilim
Copy link
Contributor Author

Propose reverting the image to windows-2019 for now. The longer term fix is to update our Windows app dependencies for the new Windows 2022 image.

@chenilim chenilim merged commit 14b2103 into main Feb 15, 2022
@chenilim chenilim deleted the workflow-windows-2019 branch February 15, 2022 21:26
@wiggin77
Copy link
Contributor

@chenilim I'm getting this same error trying to build the windows app for Windows 11 Pro. Any idea how to fix this for local build?

@chenilim
Copy link
Contributor Author

Yup, you need to install a particular version of the Windows 10 SDK - currently it's 10.0.18362.0, as specified in the <HintPath> in Focalboard.csproj. I've submitted a PR (#2348) to update this to 10.0.19041.0 (and .NET 4.8).

Alternatively, you can also change the HintPath in the .csproj file to reflect the SDK version you have installed. The file location is under C:\program files (x86))\Windows Kits\10\UnionMetadata\.

@wiggin77
Copy link
Contributor

install a particular version of the Windows 10 SDK - currently it's 10.0.18362.0,

That worked. Thanks!

@lynsei lynsei mentioned this pull request Jun 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbishel sbishel sbishel approved these changes

@wiggin77 wiggin77 wiggin77 approved these changes

@harshilsharma63 harshilsharma63 Awaiting requested review from harshilsharma63 harshilsharma63 was automatically assigned from mattermost/core-focalboard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenilim @wiggin77 @sbishel