Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Decision Needed: Default to a newer Python in our Dockerfile? #8674

Closed
callahad opened this issue Oct 27, 2020 · 4 comments · Fixed by #8698
Closed

Decision Needed: Default to a newer Python in our Dockerfile? #8674

callahad opened this issue Oct 27, 2020 · 4 comments · Fixed by #8698

Comments

@callahad
Copy link
Contributor

callahad commented Oct 27, 2020

This was raised as part of discussing #8665: We support Python 3.5 through 3.9, but our Dockerfile default is Python 3.7.

Is there any particular reason for this, or should we go full steam ahead with the latest supported Python version in our Dockerfiles since we effectively control that environment?

@ShadowJonathan
Copy link
Contributor

ShadowJonathan commented Oct 28, 2020

it's a bit balanced between "which python versions are likely to be cached locally as images?" (deduplication on admin side) and "which versions do we trust the most/do we think have the most benefit with performance and the like?" (as effectively support and benefit of 3.5 through 3.9 is indistinguishable)

Imo: Latest python release - 1 minor version

@maquis196
Copy link
Contributor

were only talking a few meg on that python layer tbh, debian-slim takes up the vast chunk of it (And didnt provide the precompiled wheels we were hoping for). Whatever version is stable, might as well (id argue keeping it at the same version as the latest ubuntu LTS or something as well, so at least any bugs would be global is how id see it - which in this case is 3.8)

@callahad
Copy link
Contributor Author

the same version as the latest ubuntu LTS or something

Ah, but which something 😉

Distro Python
RHEL 8 3.6
Debian 10 3.7
Ubuntu 20.04 3.8

If the latest version of Python is x.y, I'm inclined to go with x.(y-1). This gives us a very recent version of Python, but also one which has been around long enough for the broader ecosystem to adapt to any changes it introduces.

@maquis196
Copy link
Contributor

Im in favour of 3.8 since that matches 20.04 and matches the y-1 rule. Seems a win all round to me :). Alas, ill leave that to the grown ups!

callahad added a commit to callahad/synapse that referenced this issue Oct 31, 2020
This bumps us closer to current Python without going all the way to 3.9.

Fixes matrix-org#8674

Signed-off-by: Dan Callahan <danc@element.io>
callahad added a commit that referenced this issue Nov 2, 2020
This bumps us closer to current Python without going all the way to 3.9.

Fixes #8674

Signed-off-by: Dan Callahan <danc@element.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants