Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Upgrade Python version in Docker release #13234

Closed
melroy89 opened this issue Jul 8, 2022 · 3 comments · Fixed by #14875
Closed

Upgrade Python version in Docker release #13234

melroy89 opened this issue Jul 8, 2022 · 3 comments · Fixed by #14875
Labels
good first issue Good for newcomers T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Future-Maintenance Things that can't yet be done, but will need cleaning up in a couple of months/releases Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution
Milestone
Revisit: Next Qua...

Comments

@melroy89
Copy link

melroy89 commented Jul 8, 2022

Description:

Please update the Python version in your Docker container releases to at least Python 3.10 or higher.

I suffer from people who register on my public server, I would like to trace their IP addresses. See also: #12014 (comment)

However, I'm using the Synapse Docker image.

Latest version: Python 3.10.5

Thanks in advance.
This was referenced Jul 9, 2022
Merged
Merged
melroy89 added a commit to melroy89/synapse that referenced this issue Jul 9, 2022
@melroy89
Upgrade to python 3.10 by default (matrix-org#13234).
7ad995a
@melroy89
Copy link
Author

melroy89 commented Jul 9, 2022

PR created #13237

@DMRobertson DMRobertson linked a pull request Jul 11, 2022 that will close this issue
Upgrade to python 3.10 by default (#13234) #13237
Closed
4 tasks
@squahtx squahtx added this to the Revisit: Next Quarter milestone Jul 13, 2022
@squahtx squahtx added T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Future-Maintenance Things that can't yet be done, but will need cleaning up in a couple of months/releases and removed X-Needs-Discussion labels Jul 13, 2022
@erikjohnston erikjohnston removed this from the Revisit: Next Month milestone Nov 10, 2022
@erikjohnston erikjohnston added this to the Revisit: Next Quarter milestone Jan 5, 2023
@DMRobertson DMRobertson mentioned this issue Jan 20, 2023
Closed
@DMRobertson
Copy link
Contributor

Per #8674 (comment) we have preferred to keep the version of Python at one-less-than CPython stable. (We want to give CPython releases a few weeks at least to shake out any bugs or incompatibilities in the ecosystem).

However we have recently discussed this within the team and would be willing to bump to Python 3.11 now. If someone would like to create a PR doing this we'd gratefully accept this (cc @katlol). https://github.com/matrix-org/synapse/pull/13237/files is an example that would have sufficed for 3.9 -> 3.10

@DMRobertson DMRobertson added Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution good first issue Good for newcomers labels Jan 20, 2023
@iakat
Copy link
Contributor

iakat commented Jan 20, 2023

@DMRobertson Of course, thank you! I created #14875 for this.

@DMRobertson DMRobertson linked a pull request Jan 20, 2023 that will close this issue
Dockerfile: Bump Python version from 3.9 to 3.11 #14875
Merged
4 tasks
DMRobertson pushed a commit that referenced this issue Jan 20, 2023
@iakat
Dockerfile: Bump Python version from 3.9 to 3.11 (#14875)
cf18fea 
Closes #13234

Signed-off-by: Katia Esposito <1695469+katlol@users.noreply.github.com>

Signed-off-by: Katia Esposito <1695469+katlol@users.noreply.github.com>
Fizzadar pushed a commit to beeper/synapse-legacy-fork that referenced this issue Jan 24, 2023
@iakat @Fizzadar
Dockerfile: Bump Python version from 3.9 to 3.11 (matrix-org#14875)
8774e80 
Closes matrix-org#13234

Signed-off-by: Katia Esposito <1695469+katlol@users.noreply.github.com>

Signed-off-by: Katia Esposito <1695469+katlol@users.noreply.github.com>
# Conflicts:
#	docker/Dockerfile
Fizzadar pushed a commit to beeper/synapse-legacy-fork that referenced this issue Jan 24, 2023
@iakat @Fizzadar
Dockerfile: Bump Python version from 3.9 to 3.11 (matrix-org#14875)
6bcd595 
Closes matrix-org#13234

Signed-off-by: Katia Esposito <1695469+katlol@users.noreply.github.com>

Signed-off-by: Katia Esposito <1695469+katlol@users.noreply.github.com>
# Conflicts:
#	docker/Dockerfile
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Future-Maintenance Things that can't yet be done, but will need cleaning up in a couple of months/releases Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution
Projects
None yet
Milestone
Revisit: Next Quarter
5 participants
@melroy89 @iakat @squahtx @erikjohnston @DMRobertson