Use public Synapse imports for UserID and run_as_background_process
#175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failures seem unrelated. It seems that you based your branch on a version that had... a few CI issues :) I'm in the process of adding (some) CI for the Synapse module as part of #128, so I suggest:
|
|
@Yoric CI is happy now — if you're happy with it, please (squash) merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The general rule is:
synapse.module_apiis OK, but anywhere else is not.Luckily the other two things are already exported for public use. We don't guarantee the stability/existence of functions in other parts of the code.
Related: #173, #174.