Let's port to Synapse module API #128
Conversation
Yoric
force-pushed
the
yoric/module-api
branch
from
12ea36c to
4eac9a1
Compare
richvdh
requested review from
a team
and removed request for
turt2live and
richvdh
There was a problem hiding this comment.
Remember you'll need to update the documentation for how the module should be installed.
It looks like this change will make the module incompatible with the old API. I recommend supporting both the new API at the same time as the old one, at least for a while, so that we don't need to deploy code and config changes at the same time.
One way to do that is to leave AntiSpam as it is today - complete with definitions of all the methods like user_may_create_room required to implement the old module api - and to define a new class (for example mjolnir.Mjolnir) - which implements the new api and just wraps AntiSpam.
Yoric
force-pushed
the
yoric/module-api
branch
from
4eac9a1 to
07cb181
Compare
|
Ok, ofc we already have mx-tester build in the CI |
synapse_antispam/mjolnir/antispam.py
Outdated
| class AntiSpam(object): | ||
| def __init__(self, config, api): | ||
| self.block_invites = config.get("block_invites", True) | ||
| self.block_messages = config.get("block_messages", False) | ||
| self.block_usernames = config.get("block_usernames", False) | ||
| self.list_room_ids = config.get("ban_lists", []) | ||
| self.rooms_to_lists = {} # type: Dict[str, BanList] |
There was a problem hiding this comment.
Well, importing Dict isn't correct anymore, so I guess that this isn't either?
No description provided.