Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove origin from unsigned_pdu_base.yaml #998

Merged
merged 3 commits into from
Mar 29, 2022

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Mar 17, 2022

It doesn't serve a useful purpose, is not enforced to be present by Synapse and already being omitted by at least one homeserver implementation.

Fixes one half of #374.

Preview: https://pr998--matrix-spec-previews.netlify.app

It doesn't serve a useful purpose, is not enforced to be present by Synapse
and already being omitted by at least one homeserver implementation.
@jplatte jplatte requested a review from a team as a code owner March 17, 2022 16:38
@richvdh
Copy link
Member

richvdh commented Mar 19, 2022

LGTM otherwise, but I'd like to check if anyone else in the SCT has an opinion.

@richvdh richvdh merged commit ac9bee3 into matrix-org:main Mar 29, 2022
@jplatte jplatte deleted the rm-pdu-origin branch March 29, 2022 18:19
jplatte added a commit to ruma/ruma that referenced this pull request Mar 29, 2022
It has been removed from the spec, for details see
matrix-org/matrix-spec#998
jplatte added a commit to ruma/ruma that referenced this pull request Mar 30, 2022
It has been removed from the spec, for details see
matrix-org/matrix-spec#998
gnieto added a commit to gnieto/sytest that referenced this pull request Sep 25, 2022
Related to: matrix-org/matrix-spec#998

Setting `origin` field in PDUs is not required anymore, so I've removed
assertions and assignments to this field.
neilalexander added a commit to matrix-org/gomatrixserverlib that referenced this pull request Sep 26, 2022
neilalexander added a commit to matrix-org/gomatrixserverlib that referenced this pull request Sep 26, 2022
This nukes the `origin` field from PDUs as per
matrix-org/matrix-spec#998.
neilalexander added a commit to matrix-org/dendrite that referenced this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants