Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event format example has extra field origin in it #1480

Closed
turt2live opened this issue Apr 4, 2023 · 2 comments · Fixed by #1918
Closed

Event format example has extra field origin in it #1480

turt2live opened this issue Apr 4, 2023 · 2 comments · Fixed by #1918
Labels
spec-bug Something which is in the spec, but is wrong

Comments

@turt2live
Copy link
Member

Link to problem area: https://spec.matrix.org/v1.6/rooms/v10/#event-format-1

Issue
The format schema no longer includes origin, but it's still in the example.

Expected behaviour
Delete the origin from the example.

@turt2live turt2live added the spec-bug Something which is in the spec, but is wrong label Apr 4, 2023
@turt2live
Copy link
Member Author

This is rooted from #998

Note that v1 (and possibly other room versions) might still intend to actually use origin, making that PR incorrect in removing the field from everywhere - this needs validation.

@richvdh
Copy link
Member

richvdh commented May 30, 2023

Note that v1 (and possibly other room versions) might still intend to actually use origin, making that PR incorrect in removing the field from everywhere - this needs validation.

I'm as sure as is plausible that nothing uses origin, which was the justification for #998, and origin's subsequent removal in ruma and dendrite. It's also tested via sytest.

Johennes added a commit to Johennes/matrix-spec that referenced this issue Aug 7, 2024
Fixes: matrix-org#1480
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-bug Something which is in the spec, but is wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants