This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add device notifications enabled switch #9324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germain-gg
added
the
T-Enhancement
|
@kerryarchibald thanks for the review. Any thoughts on what could be the cause here? |
germain-gg
requested review from
kerryarchibald
and removed request for
florianduros and
SimonBrandner
added 2 commits
September 28, 2022 17:50
odelcroi
added a commit
to tchapgouv/tchap-web-v4
that referenced
this pull request
Oct 5, 2022
* Device manager - select all devices ([\#9330](matrix-org/matrix-react-sdk#9330)). Contributed by @kerryarchibald. * New group call experience: Call tiles ([\#9332](matrix-org/matrix-react-sdk#9332)). * Add Shift key to FormatQuote keyboard shortcut ([\#9298](matrix-org/matrix-react-sdk#9298)). Contributed by @owi92. * Device manager - sign out of multiple sessions ([\#9325](matrix-org/matrix-react-sdk#9325)). Contributed by @kerryarchibald. * Display push toggle for web sessions (MSC3890) ([\#9327](matrix-org/matrix-react-sdk#9327)). * Add device notifications enabled switch ([\#9324](matrix-org/matrix-react-sdk#9324)). * Implement push notification toggle in device detail ([\#9308](matrix-org/matrix-react-sdk#9308)). * New group call experience: Starting and ending calls ([\#9318](matrix-org/matrix-react-sdk#9318)). * New group call experience: Room header call buttons ([\#9311](matrix-org/matrix-react-sdk#9311)). * Make device ID copyable in device list ([\#9297](matrix-org/matrix-react-sdk#9297)). Contributed by @duxovni. * Use display name instead of user ID when rendering power events ([\#9295](matrix-org/matrix-react-sdk#9295)). * Read receipts for threads ([\#9239](matrix-org/matrix-react-sdk#9239)). Fixes #23191. * Fix device selection in pre-join screen for Element Call video rooms ([\#9321](matrix-org/matrix-react-sdk#9321)). Fixes #23331. * Don't render a 1px high room topic if the room topic is empty ([\#9317](matrix-org/matrix-react-sdk#9317)). Contributed by @Arnei. * Don't show feedback prompts when that UIFeature is disabled ([\#9305](matrix-org/matrix-react-sdk#9305)). Fixes #23327. * Fix soft crash around unknown room pills ([\#9301](matrix-org/matrix-react-sdk#9301)). Fixes matrix-org/element-web-rageshakes#15465. * Fix spaces feedback prompt wrongly showing when feedback is disabled ([\#9302](matrix-org/matrix-react-sdk#9302)). Fixes #23314. * Fix tile soft crash in ReplyInThreadButton ([\#9300](matrix-org/matrix-react-sdk#9300)). Fixes matrix-org/element-web-rageshakes#15493.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://element-io.atlassian.net/browse/PSG-783
Fixes https://element-io.atlassian.net/browse/PSG-802
Implements matrix-org/matrix-spec-proposals#3890
Adds a "enable for this device" toggle in the notifications settings.
All new session will pro-actively create a
m.local_notification_settings.<device-id>account data event with a default ofis_silenced=true.Sessions that were created before this feature lands will check whether the account data event exists, and create it if needed. The default will be
is_silenced=trueunless one of the following settings has previously been set totrue.notificationsEnabled(oddly named, but it refers to OS native push notifications)notificationBodyEnabledaudioNotificationsEnabledChecklist
Here's what your changelog entry will look like:
✨ Features