Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix device selection in pre-join screen for Element Call video rooms #9321

Merged
merged 12 commits into from
Sep 30, 2022
Merged

Fix device selection in pre-join screen for Element Call video rooms #9321

merged 12 commits into from
Sep 30, 2022

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Sep 27, 2022 •
edited by github-actions bot
Loading

As per element-hq/element-call#609

Also fix lying comment on getDevices() - it wasn't just for Electron at all - and make it a bit more descriptive.

Fixes element-hq/element-web#23331

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

@dbkr dbkr added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Sep 27, 2022
@dbkr dbkr marked this pull request as ready for review September 27, 2022 17:07
@dbkr dbkr requested a review from a team as a code owner September 27, 2022 17:07
robintown
robintown reviewed Sep 27, 2022
View reviewed changes
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The device selection buttons are still configured to show fallback labels when they don't know the actual labels. Would you be able to slip the removal of that in as well?

@dbkr
Copy link
Member Author

dbkr commented Sep 27, 2022

Yeah, although I think this will still happen, so I think we need to do more to fix this: I think by getting and holding on to a stream while we call enumerateDevices because FF only gives you names if you have an active stream or persistent permission. I was going to do this in a separate PR, although I guess this will be broken if the device names are blank, so perhaps we should bundle it into this one.

@dbkr
Copy link
Member Author

dbkr commented Sep 29, 2022

ARGH. This doesn't work in Safari. Of course it doesn't work in Safari.

robintown
robintown reviewed Sep 29, 2022
View reviewed changes
src/components/views/voip/CallLobby.tsx Outdated Show resolved Hide resolved
src/components/views/voip/CallLobby.tsx Outdated Show resolved Hide resolved
robintown
robintown suggested changes Sep 30, 2022
View reviewed changes
src/components/views/voip/CallView.tsx Outdated Show resolved Hide resolved
robintown
robintown approved these changes Sep 30, 2022
View reviewed changes
test/components/views/voip/CallView-test.tsx Outdated Show resolved Hide resolved
@dbkr dbkr merged commit 07a5a1d into develop Sep 30, 2022
@dbkr dbkr deleted the dbkr/device_by_name branch September 30, 2022 16:28
odelcroi added a commit to tchapgouv/tchap-web-v4 that referenced this pull request Oct 5, 2022
@odelcroi
Merge tag 'v1.11.9-rc.1' into upgrade/element-web-v1.11.9-rc.1
738bee5 
* Device manager - select all devices ([\#9330](matrix-org/matrix-react-sdk#9330)). Contributed by @kerryarchibald.
* New group call experience: Call tiles ([\#9332](matrix-org/matrix-react-sdk#9332)).
* Add Shift key to FormatQuote keyboard shortcut ([\#9298](matrix-org/matrix-react-sdk#9298)). Contributed by @owi92.
* Device manager - sign out of multiple sessions ([\#9325](matrix-org/matrix-react-sdk#9325)). Contributed by @kerryarchibald.
* Display push toggle for web sessions (MSC3890) ([\#9327](matrix-org/matrix-react-sdk#9327)).
* Add device notifications enabled switch ([\#9324](matrix-org/matrix-react-sdk#9324)).
* Implement push notification toggle in device detail ([\#9308](matrix-org/matrix-react-sdk#9308)).
* New group call experience: Starting and ending calls ([\#9318](matrix-org/matrix-react-sdk#9318)).
* New group call experience: Room header call buttons ([\#9311](matrix-org/matrix-react-sdk#9311)).
* Make device ID copyable in device list ([\#9297](matrix-org/matrix-react-sdk#9297)). Contributed by @duxovni.
* Use display name instead of user ID when rendering power events ([\#9295](matrix-org/matrix-react-sdk#9295)).
* Read receipts for threads ([\#9239](matrix-org/matrix-react-sdk#9239)). Fixes #23191.
* Fix device selection in pre-join screen for Element Call video rooms ([\#9321](matrix-org/matrix-react-sdk#9321)). Fixes #23331.
* Don't render a 1px high room topic if the room topic is empty ([\#9317](matrix-org/matrix-react-sdk#9317)). Contributed by @Arnei.
* Don't show feedback prompts when that UIFeature is disabled ([\#9305](matrix-org/matrix-react-sdk#9305)). Fixes #23327.
* Fix soft crash around unknown room pills ([\#9301](matrix-org/matrix-react-sdk#9301)). Fixes matrix-org/element-web-rageshakes#15465.
* Fix spaces feedback prompt wrongly showing when feedback is disabled ([\#9302](matrix-org/matrix-react-sdk#9302)). Fixes #23314.
* Fix tile soft crash in ReplyInThreadButton ([\#9300](matrix-org/matrix-react-sdk#9300)). Fixes matrix-org/element-web-rageshakes#15493.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robintown robintown robintown approved these changes

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg is a code owner automatically assigned from matrix-org/element-web-reviewers

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Device selection in EC video rooms doesn't always work
2 participants
@dbkr @robintown