Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Link contributing guide to Element Web #9220

Merged
merged 5 commits into from
Sep 1, 2022
Merged

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Aug 25, 2022

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

PR list


This change is marked as an internal change (Task), so will not be included in the changelog.


Please follow the Matrix JS/React code style as per:
https://github.com/matrix-org/matrix-react-sdk/blob/master/code_style.md
https://github.com/vector-im/element-web/blob/develop/code_style.md
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weeman1337 weeman1337 marked this pull request as ready for review August 25, 2022 13:07
@weeman1337 weeman1337 requested a review from a team as a code owner August 25, 2022 13:07
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
weeman1337 and others added 2 commits August 30, 2022 08:17
Co-authored-by: Travis Ralston <travisr@matrix.org>
Co-authored-by: Travis Ralston <travisr@matrix.org>
@weeman1337 weeman1337 merged commit b2704d5 into develop Sep 1, 2022
@weeman1337 weeman1337 deleted the weeman1337/codestyle22 branch September 1, 2022 11:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants