Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link contributing guide to Element Web #2621

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Link contributing guide to Element Web #2621

merged 1 commit into from
Sep 1, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Aug 25, 2022 •
edited by github-actions bot
Loading

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

PR list

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Tasks for the team like planning label Aug 25, 2022
This was referenced Aug 25, 2022
Merged
Closed
Merged
Merged
@weeman1337 weeman1337 marked this pull request as ready for review August 25, 2022 13:06
@weeman1337 weeman1337 requested a review from a team as a code owner August 25, 2022 13:06
duxovni
duxovni approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@duxovni duxovni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending element-hq/element-web#23153

@weeman1337 weeman1337 merged commit 207171e into develop Sep 1, 2022
@weeman1337 weeman1337 deleted the weeman1337/codestyle22 branch September 1, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duxovni duxovni duxovni approved these changes

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weeman1337 @duxovni