This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Implement deep-linking for threads (matrix.to) #7003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
October 20, 2021 13:18
germain-gg
added
X-Blocked
turt2live
approved these changes
Oct 21, 2021
germain-gg
removed
the
X-Blocked
This was referenced Dec 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#18954
Blocked by matrix-org/matrix-js-sdk#1993
The commit history looks a bit odd, the relevant commits are starting from 5109b2d onwards
⚠️ CI Broken because of failing branch matching
This PR enables deep-linking for threaded events. The only limitation to be aware of today is that if you're loading an event that is not part of your sync data, we will only fetch that event and the thread head until we can use the aggregation API.
The timeline code now relies on the Context API which is not suitable for this use-case
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://617275a84ed227e7444fc9e1--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.