Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on a reply (containing a codeblock?) breaks timeline so you can't jump-to-bottom any more. #20264

Closed
ara4n opened this issue Dec 19, 2021 · 2 comments
Closed

Clicking on a reply (containing a codeblock?) breaks timeline so you can't jump-to-bottom any more. #20264

ara4n opened this issue Dec 19, 2021 · 2 comments
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Dec 19, 2021

Steps to reproduce

  • Viewing a timeline with some replies containing codeblock
  • Click on the codeblock; jump in theory to the reply location

Outcome

  • Sometimes it jumps to the wrong place entirely
  • Sometimes it then scrolljumps immediately after
  • Sometimes the jump to bottom button does nothing

Easy to reproduce.

Have included screencap on the rageshake.

Operating system

macOS 12.0.1 on M1

Application version

Nightly

How did you install the app?

No response

Homeserver

matrix.org

Will you send logs?

Yes
@ara4n ara4n added the T-Defect label Dec 19, 2021
@germain-gg germain-gg added A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely and removed O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Dec 20, 2021
@t3chguy
Copy link
Member

t3chguy commented Jan 10, 2022

I can repro without code blocks involved, just any reply jump, presumably even all permalink jumps

@t3chguy t3chguy self-assigned this Jan 10, 2022
@aaronraimist
Copy link
Collaborator

aaronraimist commented Jan 10, 2022 •
edited
Loading

Jump to bottom being broken is #19813, regressed in matrix-org/matrix-react-sdk#7003

@t3chguy t3chguy removed their assignment Jan 10, 2022
@t3chguy t3chguy mentioned this issue Jan 10, 2022
Merged
@ara4n ara4n closed this as completed Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@germain-gg @ara4n @t3chguy @aaronraimist