Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Allow persistent resizing of the widget app drawer #5138

Merged
merged 17 commits into from
Sep 8, 2020
Merged

Allow persistent resizing of the widget app drawer #5138

merged 17 commits into from
Sep 8, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Aug 21, 2020 •
edited
Loading

pv and others added 9 commits April 30, 2020 20:14
@pv
Use flexboxes in AppTile/AppDrawer CSS for automatic resizing
2e7bd2e 
Using flexboxes removes the need for pixel constants, and the app
content now resizes to fill the tiles.

Signed-off-by: Pauli Virtanen <pav@iki.fi>
@pv
Fix resizer/sizer.js mouse event offset calculation
11438ae 
The event coordinates are document coordinates, so the offset they are
compared to should also be the document one.

Signed-off-by: Pauli Virtanen <pav@iki.fi>
@pv
Make AppsDrawer resizable by dragging its bottom border
e897e97 
Signed-off-by: Pauli Virtanen <pav@iki.fi>
@pv
Make AppsDrawer resize handle easier to grab
7358260
@t3chguy
Merge branch 'develop' of https://github.com/matrix-org/matrix-react-sdk
ae65ed5 
 into resizable-appsdrawer

� Conflicts:
�	res/css/views/rooms/_AppsDrawer.scss
@t3chguy
Switch widget resizing to re-resizable and add persistence
cca5ccd
@t3chguy
small tweaks
35cc1fb
@t3chguy
dedup
97d8cec
@t3chguy
Merge branch 'develop' of https://github.com/matrix-org/matrix-react-sdk
ef137d2 
 into t3chguy/dpsah/6785
@t3chguy t3chguy marked this pull request as ready for review August 24, 2020 13:05
@t3chguy t3chguy requested review from a team August 24, 2020 13:05
@t3chguy t3chguy mentioned this pull request Aug 24, 2020
Closed
jryans
jryans suggested changes Aug 26, 2020
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks reasonable, just a few questions.

res/css/views/rooms/_AppsDrawer.scss Outdated Show resolved Hide resolved
src/hooks/useLocalStorage.ts Outdated Show resolved Hide resolved
@t3chguy t3chguy requested a review from jryans August 27, 2020 09:46
jryans
jryans approved these changes Aug 27, 2020
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 😄

src/hooks/useLocalStorageState.ts Outdated Show resolved Hide resolved
@t3chguy @jryans
Update src/hooks/useLocalStorageState.ts
ccd08aa 
Co-authored-by: J. Ryan Stinnett <jryans@gmail.com>
nadonomy
nadonomy suggested changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t3chguy is there anything we can do to make the timeline position persist while resizing? It feels really strange now where resizing widgets to increase their height also impacts the timeline view, where it'd be better if the scroll position persisted.

@t3chguy

This comment has been minimized.

Sign in to view
@t3chguy

This comment has been minimized.

Sign in to view
@t3chguy t3chguy requested review from nadonomy and jryans September 2, 2020 11:06
bwindels
bwindels approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have looked at scroll panel and resize notifier changes, and that looks 👍

src/components/views/elements/PersistedElement.js Show resolved Hide resolved
@jryans jryans removed their request for review September 2, 2020 16:04
nadonomy
nadonomy approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feeling good, thanks!

@t3chguy
Merge branch 'develop' of https://github.com/matrix-org/matrix-react-sdk
667c129 
 into t3chguy/dpsah/6785

� Conflicts:
�	src/components/structures/ScrollPanel.js
�	src/components/views/rooms/AppsDrawer.js
@t3chguy t3chguy merged commit ddba5c6 into develop Sep 8, 2020
@t3chguy t3chguy deleted the t3chguy/dpsah/6785 branch September 8, 2020 08:47
@luixxiul luixxiul mentioned this pull request May 9, 2023
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nadonomy nadonomy nadonomy approved these changes

@jryans jryans jryans approved these changes

@bwindels bwindels bwindels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resize widget area height in room via Riot interface
5 participants
@t3chguy @bwindels @jryans @nadonomy @pv