This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Make AppsDrawer resizable by dragging its bottom border #4493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pv is it possible to make the target to drag more generous? From the video it looks like your cursor struggles to drag exactly, toggling between cursors rapidly. |
Using flexboxes removes the need for pixel constants, and the app content now resizes to fill the tiles. Signed-off-by: Pauli Virtanen <pav@iki.fi>
The event coordinates are document coordinates, so the offset they are compared to should also be the document one. Signed-off-by: Pauli Virtanen <pav@iki.fi>
Signed-off-by: Pauli Virtanen <pav@iki.fi>
pv
force-pushed
the
resizable-appsdrawer
branch
from
0acb5c9 to
9138e9e
Compare
pv
force-pushed
the
resizable-appsdrawer
branch
from
9138e9e to
7358260
Compare
|
@nadonomy: thanks, the handle indeed was half hidden behind the apptile. Fixed it, now it should be the same size as the other handles: https://raw.githubusercontent.com/pv/matrix-react-sdk/resizable-appsdrawer-media/appsdrawer-2.webm |
5 tasks
|
@pv is this video: https://raw.githubusercontent.com/pv/matrix-react-sdk/resizable-appsdrawer-media/appsdrawer-2.webm still available? i can't play it! |
|
@nurjinjafar sounds like your browser doesn't support WebM. It plays fine in Firefox |
|
Has been superceded by #5138, making use of the above commits as a foundation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make widgets resizable by dragging their bottom border with mouse. Implements element-hq/element-web#6785 (see especially element-hq/element-web#6785 (comment))
Video
Fixes element-hq/element-web#6785