Rust crypto: ensure we persist the key backup version #3770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
reviewed
Oct 3, 2023
richvdh
reviewed
Oct 3, 2023
src/rust-crypto/rust-crypto.ts
Outdated
| const base64Key = encodeBase64(key); | ||
|
|
||
| // TODO get version from backupManager | ||
| await this.olmMachine.saveBackupDecryptionKey(RustSdkCryptoJs.BackupDecryptionKey.fromBase64(base64Key), ""); | ||
| const activeVersion = version ?? (await this.backupManager.requestKeyBackupVersion())?.version; |
There was a problem hiding this comment.
It would be good to avoid the call to requestKeyBackupVersion. Can we just make version mandatory? AFAICT the caller should always have it.
There was a problem hiding this comment.
Yes I was a bit hesitant, wasn't it part of API? Mainly why I kept the existing one as deprecated
There was a problem hiding this comment.
We need to keep the old one working for old crypto. It doesn't mean we have to keep the old one working with rust crypto provided the new one works with the react-sdk.
richvdh
changed the title
richvdh
requested changes
Oct 3, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Oct 3, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#26259
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.