-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Disabled] Flaky cypress test: Device verification
> Verify device during login with QR code
#26293
Closed
richvdh opened this issue
Oct 3, 2023
· 3 comments
· Fixed by matrix-org/matrix-js-sdk#3791 or matrix-org/matrix-react-sdk#11771
Closed
[Disabled] Flaky cypress test: Device verification
> Verify device during login with QR code
#26293
richvdh opened this issue
Oct 3, 2023
· 3 comments
· Fixed by matrix-org/matrix-js-sdk#3791 or matrix-org/matrix-react-sdk#11771
Labels
A-Element-R
Issues affecting the port of Element's crypto layer to Rust
Z-Element-R-Blocker
A blocker for enabling Element R by default
Z-Flaky-Test
A test is raising false alarms
Comments
This test is actually failing with multiple different problems:
|
Disabled the test for now for rust crypto in matrix-org/matrix-react-sdk#11710 |
Generally QR code verification seems a bit flaky. Trying it myself, after the "you've verified successfully!" banner, I saw this error in the logs:
... and it seemed like the device was not, in fact, verified |
richvdh
changed the title
Flaky cypress test:
Flaky cypress test: Oct 5, 2023
Device verification
> Verify device during login with QR code
Device verification
> Verify device with QR code during login
richvdh
changed the title
Flaky cypress test:
Flaky cypress test: Oct 5, 2023
Device verification
> Verify device with QR code during login
Device verification
> Verify device during login with QR code
germain-gg
added
the
A-Element-R
Issues affecting the port of Element's crypto layer to Rust
label
Oct 9, 2023
richvdh
added a commit
to matrix-org/matrix-js-sdk
that referenced
this issue
Oct 9, 2023
The rust crypto sdk doesn't actually finish QR code verification until the `m.key.verification.done` is received, so make sure we don't tell the application it is done before that happens. Fixes element-hq/element-web#26293
github-merge-queue bot
pushed a commit
to matrix-org/matrix-js-sdk
that referenced
this issue
Oct 10, 2023
…3791) * Element-R: Don't mark QR code verification as done too soon The rust crypto sdk doesn't actually finish QR code verification until the `m.key.verification.done` is received, so make sure we don't tell the application it is done before that happens. Fixes element-hq/element-web#26293 * ignore fallback line * Revert unnecessary changes Can't get the coverage high enough on this and it's not needed.
richvdh
changed the title
Flaky cypress test:
[Disabled] Flaky cypress test: Oct 18, 2023
Device verification
> Verify device during login with QR code
Device verification
> Verify device during login with QR code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Element-R
Issues affecting the port of Element's crypto layer to Rust
Z-Element-R-Blocker
A blocker for enabling Element R by default
Z-Flaky-Test
A test is raising false alarms
matrix-org/matrix-js-sdk#3770 / https://github.com/matrix-org/matrix-js-sdk/actions/runs/6395357104/job/17358911350#step:8:5058
Given the list of found roles, including "Continue with OAuth test", it might just have been slow to log in.
The text was updated successfully, but these errors were encountered: