Try to set a sender on search result events if possible #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to ensure that search results have aesthetic information such as display name and avatar. Though the membership event won't be in context for when the event was sent, it'll at least be something better than a bare user ID.
turt2live
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Oct 28, 2021
Though not perfect, this is a bit better than it was before. Specifically, we ensure our matching for `isOwnEvent` correctly identifies the user and that the results don't look *awful*. There's still room for improvement, but this should be a measurable improvement itself. Most notably, this doesn't fix a couple obvious bugs due to complexity: * Message bubbles have the wrong corners for the display format (pre-existing). * The sender's own messages are missing avatars/names. This is just way too complex to fix. **Requires matrix-org/matrix-js-sdk#2004
t3chguy
approved these changes
Oct 28, 2021
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Nov 8, 2021
* Mark old verification methods as deprecated ([\matrix-org#1994](matrix-org#1994)). * Try to set a sender on search result events if possible ([\matrix-org#2004](matrix-org#2004)). * Port some changes from group calls branch to develop ([\matrix-org#2001](matrix-org#2001)). Contributed by @SimonBrandner. * Fetch room membership from server rather than relying on stored data ([\matrix-org#1998](matrix-org#1998)). * Add method to fetch the MSC3266 Room Summary of a Room ([\matrix-org#1988](matrix-org#1988)). * Don't show `Unable to access microphone` when cancelling screensharing dialog ([\matrix-org#2005](matrix-org#2005)). Fixes element-hq/element-web#19533 and element-hq/element-web#19533. Contributed by @SimonBrandner. * Strip direction override characters from display names ([\matrix-org#1992](matrix-org#1992)). Fixes element-hq/element-web#1712 and element-hq/element-web#1712.
t3chguy
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
May 13, 2022
* PSFD-455: Iterate on search results for message bubbles Though not perfect, this is a bit better than it was before. Specifically, we ensure our matching for `isOwnEvent` correctly identifies the user and that the results don't look *awful*. There's still room for improvement, but this should be a measurable improvement itself. Most notably, this doesn't fix a couple obvious bugs due to complexity: * Message bubbles have the wrong corners for the display format (pre-existing). * The sender's own messages are missing avatars/names. This is just way too complex to fix. **Requires matrix-org/matrix-js-sdk#2004 * Tweak opacity Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to ensure that search results have aesthetic information such as display name and avatar. Though the membership event won't be in context for when the event was sent, it'll at least be something better than a bare user ID.
Links:
Here's what your changelog entry will look like:
✨ Features