Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port some changes from group calls branch to develop #2001

Merged

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Oct 25, 2021

Type: enhancement


Should be reviewable commit-by-commit


Here's what your changelog entry will look like:

✨ Features

@SimonBrandner SimonBrandner force-pushed the feature/port-group-call-changes branch 7 times, most recently from 0c386af to a8a59f3 Compare October 25, 2021 15:30
SimonBrandner and others added 6 commits October 25, 2021 17:30
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Co-authored-by: Robert Long <robert@robertlong.me>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Co-authored-by: Robert Long <robert@robertlong.me>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Co-authored-by: Robert Long <robert@robertlong.me>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Co-authored-by: Robert Long <robert@robertlong.me>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Co-authored-by: Robert Long <robert@robertlong.me>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Co-authored-by: Robert Long <robert@robertlong.me>
@SimonBrandner SimonBrandner force-pushed the feature/port-group-call-changes branch from a8a59f3 to 5e4c99f Compare October 25, 2021 15:31
@SimonBrandner SimonBrandner marked this pull request as ready for review October 25, 2021 15:43
@SimonBrandner SimonBrandner requested a review from a team as a code owner October 25, 2021 15:43
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

Copy link
Contributor

@robertlong robertlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for extracting this from the GroupCall PR Simon! This is looking great. Just a few small comments.

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner force-pushed the feature/port-group-call-changes branch from ab811ea to 651b1d7 Compare October 26, 2021 06:01
@robertlong robertlong merged commit c35cb57 into matrix-org:develop Oct 26, 2021
@SimonBrandner SimonBrandner deleted the feature/port-group-call-changes branch October 27, 2021 05:58
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Nov 8, 2021
* Mark old verification methods as deprecated ([\matrix-org#1994](matrix-org#1994)).
* Try to set a sender on search result events if possible ([\matrix-org#2004](matrix-org#2004)).
* Port some changes from group calls branch to develop ([\matrix-org#2001](matrix-org#2001)). Contributed by @SimonBrandner.
* Fetch room membership from server rather than relying on stored data ([\matrix-org#1998](matrix-org#1998)).
* Add method to fetch the MSC3266 Room Summary of a Room ([\matrix-org#1988](matrix-org#1988)).
* Don't show `Unable to access microphone` when cancelling screensharing dialog ([\matrix-org#2005](matrix-org#2005)). Fixes element-hq/element-web#19533 and element-hq/element-web#19533. Contributed by @SimonBrandner.
* Strip direction override characters from display names ([\matrix-org#1992](matrix-org#1992)). Fixes element-hq/element-web#1712 and element-hq/element-web#1712.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants