-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port some changes from group calls branch to develop #2001
Merged
robertlong
merged 9 commits into
matrix-org:develop
from
SimonBrandner:feature/port-group-call-changes
Oct 26, 2021
Merged
Port some changes from group calls branch to develop #2001
robertlong
merged 9 commits into
matrix-org:develop
from
SimonBrandner:feature/port-group-call-changes
Oct 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0c386af
to
a8a59f3
Compare
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> Co-authored-by: Robert Long <robert@robertlong.me>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> Co-authored-by: Robert Long <robert@robertlong.me>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> Co-authored-by: Robert Long <robert@robertlong.me>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> Co-authored-by: Robert Long <robert@robertlong.me>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> Co-authored-by: Robert Long <robert@robertlong.me>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> Co-authored-by: Robert Long <robert@robertlong.me>
a8a59f3
to
5e4c99f
Compare
turt2live
reviewed
Oct 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm
robertlong
suggested changes
Oct 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for extracting this from the GroupCall PR Simon! This is looking great. Just a few small comments.
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
ab811ea
to
651b1d7
Compare
robertlong
approved these changes
Oct 26, 2021
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Nov 8, 2021
* Mark old verification methods as deprecated ([\matrix-org#1994](matrix-org#1994)). * Try to set a sender on search result events if possible ([\matrix-org#2004](matrix-org#2004)). * Port some changes from group calls branch to develop ([\matrix-org#2001](matrix-org#2001)). Contributed by @SimonBrandner. * Fetch room membership from server rather than relying on stored data ([\matrix-org#1998](matrix-org#1998)). * Add method to fetch the MSC3266 Room Summary of a Room ([\matrix-org#1988](matrix-org#1988)). * Don't show `Unable to access microphone` when cancelling screensharing dialog ([\matrix-org#2005](matrix-org#2005)). Fixes element-hq/element-web#19533 and element-hq/element-web#19533. Contributed by @SimonBrandner. * Strip direction override characters from display names ([\matrix-org#1992](matrix-org#1992)). Fixes element-hq/element-web#1712 and element-hq/element-web#1712.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: enhancement
Should be reviewable commit-by-commit
Here's what your changelog entry will look like:
✨ Features