Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use debian slim for docker builds #828

Merged
merged 3 commits into from
Aug 9, 2022
Merged

Use debian slim for docker builds #828

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24c184f
Use debian slim for docker builds
Half-Shot Aug 9, 2022
34863f9
changelog
Half-Shot Aug 9, 2022
f662d17
Update 828.bugfix
Half-Shot Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
FROM node:16-alpine AS BUILD
FROM node:16-slim AS BUILD
COPY . /tmp/src
# install some dependencies needed for the build process
RUN apk add --no-cache -t build-deps make gcc g++ python3 ca-certificates libc-dev wget git
RUN apt update && apt install -y build-essential make gcc g++ python3 ca-certificates libc-dev wget git

# Workaround for https://github.com/matrix-org/matrix-appservice-discord/issues/803
RUN git config --global url.https://github.com/.insteadOf git://github.com/

RUN cd /tmp/src \
&& yarn

FROM node:16-alpine
FROM node:16-slim
ENV NODE_ENV=production
COPY --from=BUILD /tmp/src/build /build
COPY --from=BUILD /tmp/src/config /config
Expand Down
1 change: 1 addition & 0 deletions changelog.d/828.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix docker instances not starting due to being unable to load a dynamic library.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that changelog messages should relate to the latest stable release.
This wasn't broken in the latest stable release, but got introduced in #825.