Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use debian slim for docker builds #828

Merged
merged 3 commits into from
Aug 9, 2022
Merged

Use debian slim for docker builds #828

merged 3 commits into from
Aug 9, 2022

Conversation

Half-Shot
Copy link
Contributor

Fixes #827

Matrix-appservice-bridge 5.0.0 brought in new changes (matrix-bot-sdk) which relies on compiled crypto modules. These modules do not appear to work properly on alpine.

Error: Error loading shared library ld-linux-x86-64.so.2: No such file or directory (needed by /node_modules/@matrix-org/matrix-sdk-crypto-nodejs/matrix-sdk-crypto.linux-x64-musl.node)
    at Object.Module._extensions..node (node:internal/modules/cjs/loader:1189:18)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/node_modules/@matrix-org/matrix-sdk-crypto-nodejs/index.js:159:31)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12) {
  code: 'ERR_DLOPEN_FAILED'
}

Prior experience has taught me that alpine and native rust modules tend not to blend too well, so I'm going to say we just use debian-slim for our images. We do this for the Slack/IRC/Hookshot bridges already.

@Half-Shot Half-Shot requested a review from a team as a code owner August 9, 2022 13:31
@@ -0,0 +1 @@
Fix docker instances not starting due to being unable to load a dynamic library.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that changelog messages should relate to the latest stable release.
This wasn't broken in the latest stable release, but got introduced in #825.

@Half-Shot Half-Shot requested a review from jaller94 August 9, 2022 14:15
@Half-Shot Half-Shot merged commit f8aea64 into develop Aug 9, 2022
@jaller94 jaller94 deleted the hs/use-debian-slim branch August 9, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker image doesn't start since recent changes.
3 participants