Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncamelcase some internal variables in axis.py; rename _get_tick_bboxes. #21401

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 20, 2021

It's actually returning the ticklabel bboxes, not including the
tickmarks themselves.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@tacaswell
Copy link
Member

This PR is affected by a re-writing of our history to remove a large number of accidentally committed files see discourse for details.

To recover this PR it will need be rebased onto the new default branch (main). There are several ways to accomplish this, but we recommend (assuming that you call the matplotlib/matplotlib remote "upstream"

git remote update
git checkout main
git merge --ff-only upstream/main
git checkout YOUR_BRANCH
git rebase --onto=main upstream/old_master
# git rebase -i main # if you prefer
git push --force-with-lease   # assuming you are tracking your branch

If you do not feel comfortable doing this or need any help please reach out to any of the Matplotlib developers. We can either help you with the process or do it for you.

Thank you for your contributions to Matplotlib and sorry for the inconvenience.

Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, these need tests, because there are some obvious typos.

lib/matplotlib/axis.py Outdated Show resolved Hide resolved
lib/matplotlib/axis.py Outdated Show resolved Hide resolved
@anntzer
Copy link
Contributor Author

anntzer commented Oct 20, 2021

The tests were correctly catching the typos, AFAICT. Fixing them now.

lib/matplotlib/axis.py Outdated Show resolved Hide resolved
It's actually returning the ticklabel bboxes, not including the
tickmarks themselves.
@QuLogic
Copy link
Member

QuLogic commented Oct 22, 2021

Apparently, these need tests, because there are some obvious typos.

Maybe the failing tests caused some additional paths to be missed, dropping coverage. Ironically, it appears now that the one that was correctly changed is the one with no coverage, and the ones that were missed are covered.

@QuLogic QuLogic merged commit fa0c8f8 into matplotlib:main Oct 22, 2021
@anntzer anntzer deleted the a branch October 22, 2021 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants