Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Update SkewXAxis for Matplotlib 3.6 #2667

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

dopplershift
Copy link
Member

@dopplershift dopplershift commented Sep 14, 2022

Description Of Changes

An internal method we use (to fix tight bboxes) was renamed in Matplotlib 3.6. Update the name and add an alias for older matplotlib versions.

This, together with us now using the recently released Cartopy 0.21, should fix all issues with nightly builds.

Checklist

An internal method we use (to fix tight bboxes) was renamed in
Matplotlib 3.6. Update the name and add an alias for older matplotlib
versions.
@dopplershift dopplershift added Type: Maintenance Updates and clean ups (but not wrong) Area: Plots Pertains to producing plots labels Sep 14, 2022
@dopplershift dopplershift added this to the September 2022 milestone Sep 14, 2022
@dopplershift dopplershift requested a review from a team as a code owner September 14, 2022 00:53
@dopplershift dopplershift requested review from dcamron and removed request for a team September 14, 2022 00:53
@dopplershift
Copy link
Member Author

For reference, matplotlib made the change in matplotlib/matplotlib#21401.

@dopplershift dopplershift merged commit 01f4e2d into Unidata:main Sep 16, 2022
@dopplershift dopplershift deleted the fix-matplotlib-3.6 branch September 16, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Plots Pertains to producing plots Type: Maintenance Updates and clean ups (but not wrong)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Nightly build is failing
1 participant