-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typos #1147
Merged
Merged
fix typos #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit fb89b61cdc2ccf6bda9f77f72315e01fa4ffb7d7)
(cherry picked from commit a8c0a2e05c7b6cafa16d296f91da8cb651bf9d46)
(cherry picked from commit c0554c0764a2c021689e8d73b36987b67c954f0c)
(cherry picked from commit 6c7028a9043f65f0a3596be4a429be4e03d0eb89)
(cherry picked from commit d245194e7724c2a7d153945cc86c9aa8d0b522b3)
(cherry picked from commit 066a31f6345c8a04a4ebf84efd8c80d87107e6d5)
(cherry picked from commit ec17e788ade3f43ded67c014f019770634f32a7c)
(cherry picked from commit f5b6d7e9954cae87348e21525210affda09297c1)
(cherry picked from commit 2820903f591365b17a4c3bdb36bd49ee2d84054c)
(cherry picked from commit 1be1875156e2a5a417801deb59546b167e5456c6)
(cherry picked from commit 21f4932c9bbb8664cf7b3e3c3602b6a48c747893)
(cherry picked from commit 98f10b0d5e358075d03b76834cd30c97f4fbdfe1)
(cherry picked from commit cec0b058115282168c5afc5197de3f6b5479dc4a)
Geth Merge v1.12.2 Hotfixes
* Update client.go to allow the use of paths with the heimdall url As reported to the polygon team 2 months ago in the Ankr polygon slack, the current code prevents the use of a path with the heimdall url, this was fixed in erigon erigontech/erigon@a3a6170 in response to my request by Mark Holt, and it seems this code was just copied from bor where it is incorrect too. This patch fixes that. * Add reference to path library * Fix reversed order of values in unit tests and test removal of setting u.path to rawPath (otherwise why do we need rawPath at all) seems like there were work arounds done here in bioth the unit tests AND the makeURL but logic needs to be examined
* integration-tests: update ipc path on ci tests * added devnetBorFlags in matic-cli-config.yml --------- Co-authored-by: Pratik Patil <pratikspatil024@gmail.com>
…into v1.2.3-candidate
Revert "Consistent"
…anav/fix-eth-call
internal/ethapi, graphql: fix call with state api
* should use Lock when mutating the flag * same problem in MVHashMap.Write * hole the rlock while reading WriteCell --------- Co-authored-by: zhiqiangxu <652732310@qq.com>
…1132) * changed parallel universe HF to napoli HF * integration-tests: update ipc path on ci tests (#1127) * integration-tests: update ipc path on ci tests * added devnetBorFlags in matic-cli-config.yml --------- Co-authored-by: Pratik Patil <pratikspatil024@gmail.com> * Revert "integration-tests: update ipc path on ci tests (#1127)" This reverts commit 0660fac. * using cancun for block-stm metadata instead of napoli * added a check to verify tx dependencies and test cases * fix in snapshot.chainConfig * removed snapshot.*params.BorConfig using snapshot.chainConfig.Bor instead * removed unnecessary if statement in ParallelStateProcessor.Process * addressed comment * small fix in commitTransactions * dependency calculation bug fix in miner/worker.go --------- Co-authored-by: Manav Darji <manavdarji.india@gmail.com> Co-authored-by: Arpit Temani <temaniarpit27@gmail.com>
pratikspatil024
approved these changes
Jan 29, 2024
marcello33
approved these changes
Jan 29, 2024
Thanks @rex4539 for taking out your precious time and contributing to the repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.